Remove fullscreen button from MindElixir toolbar#18
Open
DisciplinedSoftware wants to merge 2 commits intoOlegIGalkin:mainfrom
Open
Remove fullscreen button from MindElixir toolbar#18DisciplinedSoftware wants to merge 2 commits intoOlegIGalkin:mainfrom
DisciplinedSoftware wants to merge 2 commits intoOlegIGalkin:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to remove the fullscreen control from the embedded MindElixir toolbar and keep fullscreen behavior controlled by the host (VS Code / Visual Studio).
Changes:
- Adds CSS overrides in both hosts to hide the
#fullscreentoolbar item and adjust toolbar spacing. - Updates both bundled MindElixir.js copies, but currently (re-)introduces a fullscreen toolbar button and fullscreen handling code in the library bundle.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Visual Studio/CodeMindMap/MindElixir/MindElixir.js | Modifies toolbar construction and adds fullscreen handling logic. |
| Visual Studio/CodeMindMap/CodeMindMapHtml.cs | Adds host CSS to hide the fullscreen toolbar item and tweak layout. |
| VS Code/src/extension.ts | Adds host CSS to hide the fullscreen toolbar item and tweak layout. |
| VS Code/MindElixir/MindElixir.js | Same toolbar + fullscreen handling changes as the Visual Studio bundle. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commits
Notes
DisciplinedSoftware:fix/remove-fullscreen-host-sidemain