optimize get blobs #15902
Draft
optimize get blobs #15902
+832
−299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalepae
reviewed
Oct 21, 2025
| // - either enough sidecars to reconstruct the blobs.git a | ||
| // | ||
| // The skipKzgProofs parameter indicates whether to skip expensive KZG proof computations (post-Fulu optimization). | ||
| func ReconstructBlobs(block blocks.ROBlock, verifiedDataColumnSidecars []blocks.VerifiedRODataColumn, indices []int, skipKzgProofs bool) ([]*blocks.VerifiedROBlob, error) { |
There was a problem hiding this comment.
We should not return a verified blob sidecar with a missing blob proof.
It breaks the promise of what is a verified blob sidecar.
|
Regarding the KZG blob proof:
Regarding the KZG cell proofs:
|
james-prysm
commented
Oct 23, 2025
|
|
||
| // ComputeCellsAndKZGProofs computes the cells and cells KZG proofs from a given blob. | ||
| func ComputeCellsAndKZGProofs(blob *Blob) (CellsAndProofs, error) { | ||
| func ComputeCellsAndKZGProofs(blob *Blob) ([]Cell, []Proof, error) { |
There was a problem hiding this comment.
This return triggered a lot of test changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements