Skip to content

Conversation

radik878
Copy link

@radik878 radik878 commented Oct 20, 2025

What type of PR is this?

Feature

What does this PR do? Why is it needed?

Implemented filtering by public_keys before pagination while preserving original key indices for correct HD derivation paths.
Add TestServer_ListAccounts_FilterAndPagination to verify filtering and pagination behavior.

Which issues(s) does this PR fix?

  • Previously, GET /v2/validator/accounts parsed and validated query public_keys but never used them to filter results, leaving dead code and confusing behavior.
  • This was inconsistent with neighboring handlers (e.g., GetValidators, GetValidatorBalances, GetValidatorPerformance) where public_keys directly affects the response.

Other notes for review

Pagination and TotalSize now operate on the filtered set; all=true returns all filtered accounts; empty filter results return an empty list without pagination errors.

Acknowledgements

@CLAassistant
Copy link

CLAassistant commented Oct 20, 2025

CLA assistant check
All committers have signed the CLA.

@james-prysm
Copy link
Contributor

Seems like a lot of stuff is failing on linting

@radik878
Copy link
Author

Seems like a lot of stuff is failing on linting

Ohhhh yes... it's my bad, copy-paste mistake

@radik878
Copy link
Author

Seems like a lot of stuff is failing on linting

corrected, sorry for inconvenience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants