-
Notifications
You must be signed in to change notification settings - Fork 653
Add OverwriteContractCode method to ArbDebug precompile
#3867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbdebug_overwriteContractCode method to ArbDebug precompileOverwriteContractCode method to ArbDebug precompile
gligneul
previously approved these changes
Oct 21, 2025
|
I update the submodule to the head. So the PR is ready to be merged, once approved |
eljobe
previously approved these changes
Oct 21, 2025
gligneul
previously approved these changes
Oct 21, 2025
auto-merge was automatically disabled
October 21, 2025 15:03
Pull Request is not mergeable
49140d8 to
5389bc4
Compare
|
I had to add stubs for the precompiles in #3860 to make CI pass, as apparently if you must implement all the functions in the precompile interfaces, and 3860's interfaces were merged before mine on https://github.com/OffchainLabs/nitro-precompile-interfaces |
gligneul
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes NIT-3993
problem
solution
I also had to update ArbDebug's solidity interface in OffchainLabs/nitro-precompile-interfaces
^ so this should probably be reviewed first