feat(bridge): add token lists for lifi #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
chrstph-dvx
changed the title
chrstph-dvx
force-pushed
the
lifi/01-add-token-lists
branch
2 times, most recently
from
799658e to
125ef54
Compare
chrstph-dvx
commented
Oct 21, 2025
| "css:build:all": "yarn css:build && yarn workspace arb-token-bridge-ui css:build && yarn workspace portal css:build", | ||
| "css:watch:all": "yarn css:watch && yarn workspace arb-token-bridge-ui css:watch && yarn workspace portal css:watch" | ||
| "css:watch:all": "yarn css:watch && yarn workspace arb-token-bridge-ui css:watch && yarn workspace portal css:watch", | ||
| "test": "vitest --config vitest.config.ts --watch", |
There was a problem hiding this comment.
In later PR, we will need to run those tests in CI
chrstph-dvx
changed the title
chrstph-dvx
force-pushed
the
lifi/01-add-token-lists
branch
from
125ef54 to
7ee57da
Compare
chrstph-dvx
force-pushed
the
lifi/01-add-token-lists
branch
from
5f1711e to
e582e46
Compare
chrstph-dvx
force-pushed
the
lifi/01-add-token-lists
branch
from
e582e46 to
ec34762
Compare
chrstph-dvx
force-pushed
the
lifi/01-add-token-lists
branch
from
ec34762 to
0c01300
Compare
fionnachan
reviewed
Oct 30, 2025
|
|
||
| const BASE_TOKEN_LIST = { | ||
| name: TOKEN_LIST_NAME, | ||
| timestamp: STATIC_TIMESTAMP, |
There was a problem hiding this comment.
is this fixed timestamp intentional so that we update it only when we have a token list version bump?
There was a problem hiding this comment.
Can you please add native USDC on Ethereum, native USDC on Arb One, and wrapped USDC.e on Arb One as test cases?
| }, | ||
| }, | ||
| ); | ||
| } catch (error: any) { |
There was a problem hiding this comment.
unknown would be a better type here as it's explicitly asserted
Comment on lines
+38
to
+96
| if (parentChainId === null || childChainId === null) { | ||
| return NextResponse.json( | ||
| { | ||
| ...BASE_TOKEN_LIST, | ||
| tokens: [], | ||
| }, | ||
| { | ||
| status: 400, | ||
| headers: { | ||
| 'Cache-Control': 'public, max-age=60, s-maxage=60', | ||
| }, | ||
| }, | ||
| ); | ||
| } | ||
|
|
||
| if (!allowedLifiSourceChainIds.includes(parentChainId)) { | ||
| return NextResponse.json( | ||
| { | ||
| ...BASE_TOKEN_LIST, | ||
| tokens: [], | ||
| }, | ||
| { | ||
| status: 400, | ||
| headers: { | ||
| 'Cache-Control': 'public, max-age=60, s-maxage=60', | ||
| }, | ||
| }, | ||
| ); | ||
| } | ||
|
|
||
| if (!allowedLifiDestinationChainIds.includes(childChainId)) { | ||
| return NextResponse.json( | ||
| { | ||
| ...BASE_TOKEN_LIST, | ||
| tokens: [], | ||
| }, | ||
| { | ||
| status: 400, | ||
| headers: { | ||
| 'Cache-Control': 'public, max-age=60, s-maxage=60', | ||
| }, | ||
| }, | ||
| ); | ||
| } | ||
|
|
||
| if (!lifiDestinationChainIds[parentChainId]?.includes(childChainId)) { | ||
| return NextResponse.json( | ||
| { | ||
| ...BASE_TOKEN_LIST, | ||
| tokens: [], | ||
| }, | ||
| { | ||
| status: 400, | ||
| headers: { | ||
| 'Cache-Control': 'public, max-age=60, s-maxage=60', | ||
| }, | ||
| }, | ||
| ); | ||
| } |
There was a problem hiding this comment.
are these conditions going to have different responses with the tokens: [] eventually? otherwise would be better to combine the conditions into a bracket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack created with Aviator.
masterSummary
Steps to test