Replaced jaeger with tempo and OTLP #318
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinebit
requested review from
OisinKyne,
KaloyanTanev,
DiogoSantoss and
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the existing Jaeger tracing setup with Tempo using OTLP settings for charon v1.4.x.
- Removed Jaeger configuration and related environment variables
- Added Tempo configuration file and updated corresponding Grafana datasource and compose configuration
Reviewed Changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tempo/tempo.yaml | New configuration file for Tempo with OTLP settings |
| grafana/datasource.yml | Updated Grafana datasource configuration to include Tempo |
| compose-debug.yml | Removed Jaeger service; added Tempo service and updated charon settings |
Files not reviewed (3)
- .env.sample.holesky: Language not supported
- .env.sample.hoodi: Language not supported
- .env.sample.mainnet: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For charon v1.4.x:
Same settings were tested with kurtosis-charon.