Repository navigation
feat(proxy): single all-in-one binary by default (CLI + TUI + GUI + MCP) - #187
Merged
Merged
Conversation
…GUI + MCP) Make `gui` a default feature so a plain `cargo build` / `make proxy` produces one binary with every front-end: headless CLI, terminal UI (tui), desktop GUI (gui) and the MCP server. It still runs on headless servers - the GUI's graphics libraries are only loaded when the window is actually opened. - Cargo: default = ["mitm", "gui"]. - A minimal binary with no GUI/graphics or TLS-interception deps is still available via `--no-default-features` (+ `--features mitm` for TLS interception); `make proxy-min` builds it. In that build the `gui` command explains how to get the GUI back and points to `tui`. - Docs (README, docs/proxy.md) and Makefile updated (proxy = all-in-one, proxy-min = minimal). Verified: default all-in-one build + 57 unit tests pass; `--no-default-features` minimal build compiles and handles `gui` gracefully; fmt clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Answers "can't we have a single binary for everything?" — yes. It already was one binary with all subcommands; the GUI was just gated behind an opt-in feature. This makes
guia default feature, so a plaincargo build/make proxyyields the do-everything binary.Change
default = ["mitm", "gui"]inproxy-rs/Cargo.toml.run), terminal UI (tui), desktop GUI (gui), MCP server (mcp), plusca/export.offat-proxy gui), so servers are unaffected.cargo build --no-default-features(optionally--features mitm) drops the GUI/graphics and TLS-interception dependencies;make proxy-minbuilds it. In that build, theguicommand explains how to get the GUI back and points totui.README,docs/proxy.md) and Makefile updated (proxy= all-in-one,proxy-min= minimal).Verification
cargo fmt --checkclean.--no-default-featuresminimal build compiles and theguicommand prints the right guidance.offat-proxy --helplistsrun|tui|gui|mcp|ca|export.