Repository navigation
[1.02] Revise 10.4.7 for project-declared MCP servers and add 10.4.22 - #1218
Conversation
6026a6e to
10eefe4
Compare
| | **10.4.5** | **Verify that** all MCP transports enforce maximum payload size limits. | 2 | | ||
| | **10.4.6** | **Verify that** MCP servers sign tool responses with a unique nonce and timestamp so MCP clients can detect replay attempts. | 2 | | ||
| | **10.4.7** | **Verify that** MCP clients present users with explicit consent dialogue and cancellation options upon installation of a local MCP server. | 2 | | ||
| | **10.4.7** | **Verify that** MCP clients require explicit approval before installing or launching each local MCP server, including servers declared in project or workspace configuration. Approval prompts display the command and arguments and allow cancellation. Neither workspace trust nor an approval setting supplied by the project or workspace satisfies this requirement. | 2 | |
There was a problem hiding this comment.
Is "including servers declared in project or workspace configuration" needed? Just makes the requirement longer than probably needed. I think the requirement in itself a good idea, but maybe we can soften it a bit so it doesn't just work on project or workspace configurations but just in general.
How about:
Verify that MCP clients do not launch a local MCP server until the user has explicitly approved its exact command and arguments, and that no setting or trust state supplied by the server’s own configuration source can grant that approval in advance.
There was a problem hiding this comment.
Thanks @RicoKomenda, agreed, the general form is better and still covers project-declared servers. I pushed it with two things kept from Otto's version: "install or", since install steps (npx/uvx) can run code before launch, and the explicit exclusion of workspace or folder trust and of approval settings from the project or workspace. Folder trust is granted by the user, not supplied by the config, and in three of the eight clients I tested, accepting the folder-trust prompt started the declared server with no further question. Appendix B row updated to match. Happy to drop either if you'd prefer it shorter.
|
Rest looks good |
RicoKomenda
left a comment
There was a problem hiding this comment.
I like it now.
@ottosulin / @jmanico please go again for the revised version, but from my perspective, it's good to go!
jmanico
left a comment
There was a problem hiding this comment.
Thanks @paolocostanzo and @RicoKomenda. Rico's shorter 10.4.7 reads well, and keeping "install or" and the explicit workspace/folder-trust exclusion was the right call.
On the open question: no need to add "complete". "Exact command and arguments" already covers it.
Merging. 🙏
Closes #1202. Implements the wording agreed in the issue (Otto's split, confirmed by Jim) in
1.02-dev/en/.Scope
Current 10.4.7 (L2):
Coding agents also launch servers declared in project configuration, with no installation step; in some clients, accepting the folder-trust prompt starts them with no separate question. This PR covers the launch decision (10.4.7) and changes to what an approved server runs (new 10.4.22). It materially modifies 10.4.7 (level unchanged) and appends 10.4.22; nothing is renumbered.
What changed
Validation
markdownlint and cspell with the repository configs, and
git diff --check: no new findings againstmain(7a2ee05).Sources
.vscode/mcp.jsonand.mcp.jsonservers inherit Workspace Trust and can start without a separate prompt, including after configuration changes): https://code.visualstudio.com/docs/agents/run/manage-mcp-servers#_mcp-server-trustKnown limitations