Skip to content

[1.02] Revise 10.4.7 for project-declared MCP servers and add 10.4.22 - #1218

Merged
jmanico merged 2 commits into
OWASP:mainfrom
paolocostanzo:issue-1202-launch-approval
Nov 11, 2026
Merged

jmanico merged 2 commits into
OWASP:mainfrom
paolocostanzo:issue-1202-launch-approval

Conversation

@paolocostanzo

Copy link
Copy Markdown
Contributor

Closes #1202. Implements the wording agreed in the issue (Otto's split, confirmed by Jim) in 1.02-dev/en/.

Scope

Current 10.4.7 (L2):

Verify that MCP clients present users with explicit consent dialogue and cancellation options upon installation of a local MCP server.

Coding agents also launch servers declared in project configuration, with no installation step; in some clients, accepting the folder-trust prompt starts them with no separate question. This PR covers the launch decision (10.4.7) and changes to what an approved server runs (new 10.4.22). It materially modifies 10.4.7 (level unchanged) and appends 10.4.22; nothing is renumbered.

What changed

  • 10.4.7 (L2): Otto's text, split into three sentences as Jim suggested; no wording change.
  • 10.4.22 (L2, new): approval bound to the launch configuration; same logic as 10.4.10 for endpoints.
  • Appendix A: "Launch Configuration", as drafted by Otto.
  • Appendix B (AD.19): C10.4.7 row updated, C10.4.22 row added.
  • Appendix C (AC.3): cross-reference note to C10.4.7 and C10.4.22.

Validation

markdownlint and cspell with the repository configs, and git diff --check: no new findings against main (7a2ee05).

Sources

Known limitations

  • 10.4.22 goes beyond the MUSTs in the MCP Security Best Practices, which cover one-click configuration.
  • Per the agreed glossary entry, changes to the contents of a referenced environment file or to the client's sandbox policy do not require re-approval under 10.4.22.
  • Re-approval after configuration changes is not measured; the evidence for it is client documentation.
  • Open question: Jim's first draft and the MCP guidance say "complete" command / "without truncation". Happy to add "complete" to 10.4.7 if you agree.

@paolocostanzo
paolocostanzo force-pushed the issue-1202-launch-approval branch from 6026a6e to 10eefe4 Compare November 9, 2026 08:54
Comment thread 1.02-dev/en/0x10-C10-MCP-Security.md Outdated
| **10.4.5** | **Verify that** all MCP transports enforce maximum payload size limits. | 2 |
| **10.4.6** | **Verify that** MCP servers sign tool responses with a unique nonce and timestamp so MCP clients can detect replay attempts. | 2 |
| **10.4.7** | **Verify that** MCP clients present users with explicit consent dialogue and cancellation options upon installation of a local MCP server. | 2 |
| **10.4.7** | **Verify that** MCP clients require explicit approval before installing or launching each local MCP server, including servers declared in project or workspace configuration. Approval prompts display the command and arguments and allow cancellation. Neither workspace trust nor an approval setting supplied by the project or workspace satisfies this requirement. | 2 |

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "including servers declared in project or workspace configuration" needed? Just makes the requirement longer than probably needed. I think the requirement in itself a good idea, but maybe we can soften it a bit so it doesn't just work on project or workspace configurations but just in general.

How about:

Verify that MCP clients do not launch a local MCP server until the user has explicitly approved its exact command and arguments, and that no setting or trust state supplied by the server’s own configuration source can grant that approval in advance.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RicoKomenda, agreed, the general form is better and still covers project-declared servers. I pushed it with two things kept from Otto's version: "install or", since install steps (npx/uvx) can run code before launch, and the explicit exclusion of workspace or folder trust and of approval settings from the project or workspace. Folder trust is granted by the user, not supplied by the config, and in three of the eight clients I tested, accepting the folder-trust prompt started the declared server with no further question. Appendix B row updated to match. Happy to drop either if you'd prefer it shorter.

@RicoKomenda

Copy link
Copy Markdown
Collaborator

Rest looks good

@RicoKomenda RicoKomenda left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it now.

@ottosulin / @jmanico please go again for the revised version, but from my perspective, it's good to go!

@jmanico jmanico left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @paolocostanzo and @RicoKomenda. Rico's shorter 10.4.7 reads well, and keeping "install or" and the explicit workspace/folder-trust exclusion was the right call.

On the open question: no need to add "complete". "Exact command and arguments" already covers it.

Merging. 🙏

@jmanico
jmanico merged commit f8d96f9 into OWASP:main Nov 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C10.4] No requirement covers MCP servers declared in project configuration and started on folder trust

3 participants