Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize ElastAlert installation #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

micwiel
Copy link
Contributor

@micwiel micwiel commented Nov 18, 2020

Made the role a little bit faster.

vars/main.yml Outdated
@@ -1,7 +1,4 @@
---
host_name: localhost
port: 9300
rule_dir: rules
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we have removed this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of https://docs.ansible.com/ansible/latest/user_guide/playbooks_variables.html#understanding-variable-precedence
In current version I can't set these variables in playbook if they are defined on role level (instead of using defaults for that case).

@iamabhishek-dubey
Copy link
Member

Can you please resolved the conflicts?

@micwiel
Copy link
Contributor Author

micwiel commented Feb 10, 2021

Resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants