CQ: Start enforcing I001: Import sorting #6577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruff rule: https://docs.astral.sh/ruff/rules/unsorted-imports/ Starts applying to simple cases, and not too big folders, where there shouldn't be issues with import order matters.
This reverts commit 66cc980.
github-actions
bot
added
vector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruff rule: https://docs.astral.sh/ruff/rules/unsorted-imports/
Starts applying to simple cases, and not too big folders, where there shouldn't be issues with import order matters.
Adjusted the configuration of ruff for it to understand what is first party vs third party (using
-vverbose output to catch what was going on) as there was a difference locally and in CI.