t.rast.extract: Handle fully qualified map names and semantic labels #6300
+307
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoix
reviewed
Sep 2, 2025
temporal/t.rast.extract/testsuite/test_t_rast_extract_pytest.py
Outdated
Show resolved
Hide resolved
wenzeslaus
previously requested changes
Sep 3, 2025
temporal/t.rast.extract/testsuite/test_t_rast_extract_pytest.py
Outdated
Show resolved
Hide resolved
temporal/t.rast.extract/testsuite/test_t_rast_extract_pytest.py
Outdated
Show resolved
Hide resolved
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
temporal/t.rast.extract/testsuite/test_t_rast_extract_pytest.py
Outdated
Show resolved
Hide resolved
temporal/t.rast.extract/testsuite/test_t_rast_extract_pytest.py
Outdated
Show resolved
Hide resolved
temporal/t.rast.extract/testsuite/test_t_rast_extract_pytest.py
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
I had to address semantic_labels better as well. They were introduced after the extract module was created... The new tests cover semantic labels... |
|
Hm,,, The added pytest fails because it runs rather as part of the gunit-test than as part of the pytest-tests. See: https://github.com/OSGeo/grass/actions/runs/18696852922/job/53316444491?pr=6300#step:17:29 |
|
The testsuite folders are for gunittest. |
|
Tests are passing now... |
echoix
approved these changes
Oct 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR appends semantic labels to the basename when expression is given for extraction of raster maps and handles fully qualified STRDS names more reliably. It also adds a pytest based testcase.
Fixes #6254