i.evapo.mh: add test file #5519
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Python
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a comprehensive regression test suite for the
i.evapo.mhmodule in GRASS GIS. These tests are designed to detect unintended changes in computational results and ensure consistent evapotranspiration output under various input scenarios and module flag settings.Changes Made
Implemented tests for:
Output clamping with
-zflag (test_z_flag_negative_values)Ensures that negative ET values are set to zero as expected.
Precipitation exclusion with
-hflag (test_h_flag_precipitation_ignored)Confirms that results remain unchanged when precipitation is omitted under the
-hflag.Alternative scaling behavior with
-sflag (test_s_flag_different_output)Verifies that the
-sflag produces different output from the default mode.Hargreaves formula consistency (
test_hargreaves_formula)Cross-validates module output against the original Hargreaves reference implementation using known inputs.
Performance
This PR significantly improves the test coverage for
i.evapo.mh. Looking forward to feedback or suggestions for further refinement!I have found a bug in the module implementation. The attached issue is #5520