[Bug] Unable to install r.valley.bottom

[williamlai2]

Name of the addon
r.valley.bottom

Describe the bug
Not able to install via GUI nor command line

To Reproduce
Steps to reproduce the behaviour:

Via command line:
g.extension r.valley.bottom

C:\PROGRA1\QGIS331.7\apps\grass\grass83\etc\python\grass\script\task.py:462: SyntaxWarning: invalid escape sequence '?'
pattern = re.compile(b'<?xml[^>]\Wencoding="([^"])"[^>]*?>')
Downloading precompiled GRASS Addons <r.valley.bottom>...
Fetching <r.valley.bottom> from
http://wingrass.fsv.cvut.cz/grass83/addons/grass-8.3.2/r.valley.bottom.zip
(be patient)...
Updating extensions metadata file...
Updating extension modules metadata file...
WARNING: No metadata available for module 'r.valley.bottom': Unable to
fetch interface description for command '<r.valley.bottom>'.

Details:
ERROR: Unable to read manual page: [Errno 2] No such file or directory:
'C:\Users\laiw\AppData\Roaming\GRASS8\addons\docs\html\r.valley.bottom.html'

If I put the html from https://github.com/OSGeo/grass-addons/blob/grass8/src/raster/r.valley.bottom/r.valley.bottom.html into that location, I get this:

C:\PROGRA1\QGIS331.7\apps\grass\grass83\etc\python\grass\script\task.py:462: SyntaxWarning: invalid escape sequence '?'
pattern = re.compile(b'<?xml[^>]\Wencoding="([^"])"[^>]*?>')
Downloading precompiled GRASS Addons <r.valley.bottom>...
Fetching <r.valley.bottom> from
http://wingrass.fsv.cvut.cz/grass83/addons/grass-8.3.2/r.valley.bottom.zip
(be patient)...
Updating extensions metadata file...
Updating extension modules metadata file...
WARNING: No metadata available for module 'r.valley.bottom': Unable to
fetch interface description for command '<r.valley.bottom>'.

Details:
Installation of <r.valley.bottom> successfully finished

However, the installation still doesn't work.

Expected behaviour
It should install properly

Screenshots
If applicable, add screenshots to help explain your problem.

System description (please complete the following information):

• Operating System: Windows 11
• GRASS GIS version Grass GIS 8.3.2 running from QGIS 3.34 installation

Additional context
Add any other context about the problem here.

[williamlai2]

I also tried the solution from here, it didn't work.

https://gis.stackexchange.com/questions/474069/cannot-install-grass-addons-in-grass-8-2-ubuntu-jammy

Same as the first error.

g.extension extension=r.valley.bottom url="C:/Users/laiw/Downloads/r.valley.bottom"

C:\PROGRA1\QGIS331.7\apps\grass\grass83\etc\python\grass\script\task.py:462: SyntaxWarning: invalid escape sequence '?'
pattern = re.compile(b'<?xml[^>]\Wencoding="([^"])"[^>]*?>')
Downloading precompiled GRASS Addons <r.valley.bottom>...
Fetching <r.valley.bottom> from
http://wingrass.fsv.cvut.cz/grass83/addons/grass-8.3.2/r.valley.bottom.zip
(be patient)...
Updating extensions metadata file...
Updating extension modules metadata file...
WARNING: No metadata available for module 'r.valley.bottom': Unable to
fetch interface description for command '<r.valley.bottom>'.

Details:
ERROR: Unable to read manual page: [Errno 2] No such file or directory:
'C:\Users\laiw\AppData\Roaming\GRASS8\addons\docs\html\r.valley.bottom.html'

[petrasovaa]

Just checking, have you tried to run it anyway? The missing html file might not influence it.

[williamlai2]

Hi @petrasovaa, I tried running it, but it couldn't find the extension.

[hellik]

Is the script and the related bat-file in C:\Users\laiw\AppData\Roaming\GRASS8\addons

[williamlai2]

Where can I find the .bat file?

I have only tried with the files in https://github.com/OSGeo/grass-addons/tree/grass8/src/raster/r.valley.bottom and that doesn't have a .bat file.

I have just now tried installing in separate instances with that folder in C:\Users\laiw\AppData\Roaming\GRASS8\addons and C:\Users\laiw\AppData\Roaming\GRASS8\addons\scripts

[hellik]

The related bat-file is generated during addon compilation and should be in the bin-subfolder

[williamlai2]

My C:\Users\laiw\AppData\Roaming\GRASS8\addons\bin folder is completely empty.

[petrasovaa]

I would suggest installing latest stable GRASS (8.4.2) and install the extension from there...

[williamlai2]

I'll try, but I am on a work computer and they are very picky about software versions.

Thanks for your help anyway.

[neteler]

Understood.
The bug you report has been fixed in subsequent versions. Say, it's totally worth it to convince the management that a newer GRASS version is better :)

[williamlai2]

I'll try and get them to approve the use of the newer version. Thanks again for looking into this.