gnm: avoid redundant root path cost re-summation in KShortestPaths#14091
Open
KinshukSS2 wants to merge 1 commit intoOSGeo:masterfrom
Open
gnm: avoid redundant root path cost re-summation in KShortestPaths#14091KinshukSS2 wants to merge 1 commit intoOSGeo:masterfrom
KinshukSS2 wants to merge 1 commit intoOSGeo:masterfrom
Conversation
Member
|
CC @BishopGIS |
Contributor
Author
|
any updates on the status of the pr...pls let me know if any changes are required from my side |
Collaborator
Waiting for someone to review. You know, this is open source, there are not many people who know gnm well, and there are also other things going on https://github.com/OSGeo/gdal/pulse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
description
the current method to find costs was that whenever a path was found then it usually checks the cost from the start thus making it less efficient
the fix i propose usually only plays a better role when there is a presence of long paths in large GNM networks
it basically only finds the cost for the new branches whenever created
fixes #14090