[HYRAX-1865] Patch for the 403 situation #241
Conversation
hannahilea
changed the title
|
| } | ||
| } | ||
| catch (Forbidden http_403){ | ||
| log.error("Unable to validate Authorization header. Message: "+http_403.getMessage()); |
There was a problem hiding this comment.
There's a reason this was not throwing an exception prior to this. Throwing an exception here will break things - we need to reevaluate this bug and see if there's a better way to fix it.
hannahilea
left a comment
hannahilea
left a comment
There was a problem hiding this comment.
As of merging #240, the but this ticket addresses seems to already have been fixed on master?! I think the next step here is to confirm that the bug no longer reproduces---after which point we can probably close this PR without merging.
(Longer convo on Slack/repro steps in the the hyrax-1865 ticket.)
jgallagher59701
left a comment
jgallagher59701
left a comment
There was a problem hiding this comment.
I'm going to approve this - meaning that you two know what's going on and I'm out of the loop. So, what you all decide, goes. If you want me to look over other tickets to get context, let me know.
I think this is a patch for the bug Hannah brought up in standup where an EDL 403 gets returned incorrectly as a 500 error.