Migrate OLFS code from JavaEE 8 to Jakarta EE 9 for Tomcat 11 #223
Conversation
decided to change all the package names in the servlet-api. Nice. Thanks for that. With this branch we move to catalina-11.0.7 and servlet-api-6.1
dh-opendap
left a comment
dh-opendap
left a comment
There was a problem hiding this comment.
Looks good. Need to determine if memcached session manager works with catalian-11.0.7 before merging.
|
I think we should try it with a Tomcat 11 deployment! I have no idea if t works, just that it compiles. |
|
Agreed, let's try this with memcached. |
dh-opendap
left a comment
dh-opendap
left a comment
There was a problem hiding this comment.
Woth trying with memcached session manager
|
…ext and not json. Dropped unused getEchoTokenValue() method
…aining the Gson serialized UserProfile is now added/retrieved to/from the Session object.
ndp-opendap
requested review from
dh-opendap,
hannahilea and
jgallagher59701
|
So now that this works with RHEL-9, Tomcat-11, and Redis we have to decide if it's "time to migrate" Not insignificant because we have to bring libdap4, bes-deps, and the bes along for the ride to RHEL-9. |
|
jgallagher59701
left a comment
jgallagher59701
left a comment
There was a problem hiding this comment.
Looks good - Pretty simple change with a massive footprint.
hannahilea
left a comment
hannahilea
left a comment
There was a problem hiding this comment.
We have to decide if it's "time to migrate", which is not insignificant because we have to bring libdap4, the new bes-deps, and the bes along for the ride to RHEL-9.
Do we have a ticket w/ acceptance criteria for this? If it turns out we don't want to take this on right now, probably worth filing a ticket with how to pick it up in the future and then closing the PR (without merging).
(I'll be honest, only "requesting changes" instead of letting it linger so that I stop getting pinged daily for review by my slackbot...)
Session ManagementCurrently we are using Q: Is there an epic in the JIRA for this migration to Redis? Related |
|
Here is a potential solution for HYRAX-1754
With this PR we move to Tomcat-11 and the java
servlet-api-6.1In migrating our code to use the java
servlet-api-6.x(Where some group of deciders decided to change all the package names in the servlet-api. Nice, thanks for that.) we find there is a surprising amount of phaphphing about to do.Update: This is working on RHEL-9 with Tomcat-11, and the Redis session manager.
We have to decide if it's "time to migrate", which is not insignificant because we have to bring
libdap4, the newbes-deps, and thebesalong for the ride to RHEL-9.