Skip to content

Conversation

@anischali
Copy link

No description provided.

return TEE_SUCCESS;
}
#endif

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PTA is not the best place for this function. I'd rather have it as a driver in core/drivers/dummy_cntpct_rng.c guarded by CFG_DUMMY_CNTPCT_RNG.

But more fundamentally: how is this better than the software PRNG that OP-TEE uses by default on QEMU? (CFG_WITH_SOFTWARE_PRNG=y). If you want better randomness on QEMU then I would recommend implementing a RNG based on the RNDR instruction (which is supported by QEMU with -cpu max). That would also benefit real hardware (ARMv8.5+).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks for taking the time, I will give a try for soft prng but my need is to see how the bootloader interfaces with hwrng, in my case I use arm64 qemu to emulate TF-A >> optee >> barebox and the a kernel. so barebox implements hwrng uuid so I added this for test with qemu and I thought it would interessting to send main line for educational purposes. but the best would be to implement a virtio to benefit from what qemu exposes. there is much more work to do for that. anyway maybe it is not so relevent to have the feature in ML

@github-actions
Copy link

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Nov 13, 2025
@github-actions github-actions bot closed this Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants