Add Versal Net Documentation #261

jcorbier · 2025-02-06T17:09:05Z

Add documentation for the AMD/Xilinx Versal Net variant of the Versal family.

jenswi-linaro · 2025-02-07T07:13:13Z

building/devices/versal_net.rst

+	TEE test application done!
+
+.. note::
+	The ``regression 4005.7`` test failure is a known documented failure. The Versal Net


How about fixing this regression? It must be easier than keeping track of this technical dept.

This is fixed now. I removed the note. Sorry for the noise.

jenswi-linaro · 2025-02-07T07:19:09Z

building/devices/versal_net.rst

+
+	The pin used can be modified in ``core/pta/versal/test_pta.c`` by changing ``GPIO_TEST_PIN_ID``.
+
+This test is available in the ``versal`` testsuite in ``xtest``:


I can't find that in xtest.

These tests won't be upstreamed. This section of the doc was mostly AMD/Xilinx internal discussion. I removed it.

github-actions · 2025-03-10T01:40:46Z

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.

jenswi-linaro · 2025-03-10T08:19:56Z

Are the two commits supposed to be merged? I don't see much point in adding stuff that is immediately removed in the next commit.

jcorbier · 2025-03-10T09:51:39Z

My bad. The removals should have been squashed with the first commit, not the second one :( Fixing this right away.

jenswi-linaro · 2025-03-10T13:03:15Z

building/devices/versal_net.rst

+Prerequisites
+*************
+
+This port requires proprietary binaries available upon request to AMD/Xilinx:


Do you have a link to where to request this?

Do you have a link to where to request this?

I don't. The request has to go through AMD/Xilinx contacts first. There is no online form as far as I know.

[email protected]?

Or perhaps you know who to contact if you have such a device?

I believe you should know who to contact if you have such a device.

@nathan-menhorn Do you have any suggestion here?

Hi @jcorbier and @jenswi-linaro these binaries are only available under NDA for this product. If you could update the wording to "This port requires proprietary binaries available upon request from your AMD-Xilinx FAE:"

For some reason, I don't seem to have received notifications for these last comments, sorry about that. I'm pushing an update with your proposed wording, @nathan-menhorn

github-actions · 2025-05-05T02:17:26Z

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.

nathan-menhorn · 2025-05-05T02:32:33Z

Hi @jenswi-linaro I'm good with @jcorbier latest wording

etienne-lms · 2025-05-05T09:30:46Z

building/devices/versal_net.rst

+
+    - The third one, usually ``/dev/ttyUSB2`` is used by U-Boot and Linux for their console
+    - The fourth one, usually ``/dev/ttyUSB3`` displays PLM, TF-A and OP-TEE traces
+      (OP-TEE traces will be moved to the other UART in a future updage)


s/updage/update/

etienne-lms · 2025-05-05T09:33:35Z

building/devices/versal_net.rst

+   available in the ``PATH``. They can be downloaded and `installed`_ from the AMD-Xilinx
+   website (`Downloads`_).
+
+   The user these executables are run with should also have the correct UNIX access rights


Rephrasing?

- The user these executables are run with should also have (...) + The user that runs these executables should also have (...)

(edited) Actually I think I'm wrong. The sentence is right as-is. Discard my comment and sorry for the noise.

etienne-lms · 2025-05-05T09:34:26Z

building/devices/versal_net.rst

+===============================
+
+To properly boot Linux with the current configuration, stop automatic boot by pressing the spacebar to get to
+U-Boot prompt, the run the following command:


s/the/then/

etienne-lms · 2025-05-05T09:36:44Z

building/devices/versal_net.rst

+PUF
+===
+
+The Versal Net Physically Unclonable Function is support on the OP-TEE port.


s/support/supported/

jcorbier · 2025-05-05T14:56:33Z

@etienne-lms Thanks for the review. Fixed all the typos.

jenswi-linaro · 2025-05-06T06:26:05Z

building/devices/versal_net.rst

+
+.. code-block:: console
+
+	$ mkdir ~/optee-project


I'd rather drop the ~ to show that the tree can be anywhere. That's consistent with https://optee.readthedocs.io/en/latest/building/gits/build.html#step-3-get-the-source-code

Indeed, good point thanks.

jenswi-linaro · 2025-05-06T07:42:15Z

Acked-by: Jens Wiklander <[email protected]>

github-actions · 2025-06-06T02:17:34Z

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.

etienne-lms

Acked-by: Etienne Carriere <[email protected]>

Add relevant documentation to allow booting a buildroot image (BOOT.BIN containing firmware/tf-a/op-tee/uboot) from JTAG. Signed-off-by: Jeremie Corbier <[email protected]> Acked-by: Jens Wiklander <[email protected]> Acked-by: Etienne Carriere <[email protected]>

Add the AMD/Xilinx Versal Net Platform. Signed-off-by: Jeremie Corbier <[email protected]> Acked-by: Jens Wiklander <[email protected]> Acked-by: Etienne Carriere <[email protected]>

jcorbier · 2025-06-12T05:53:32Z

Why has this PR been closed?

jockebech · 2025-06-12T08:19:56Z

Why has this PR been closed?

The reason is that no activity means that the bot will close it automatically after some time. Don't worry though, I've reopened it. The reason I haven't merged this, is because I wanted to see that their is agreement and a conclusion on the PR about plat-versal before merging this (OP-TEE/optee_os#6738). I find it difficult to understand where we are with #6738 in optee_os.

jcorbier · 2025-06-12T08:24:46Z

No worries. I thought the latest force push (with Etienne's ack) would be enough to remove the stale state, hence my surprise. As for the status on the other PR, let me check with @nathan-menhorn. Thanks!

github-actions · 2025-07-13T02:36:16Z

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.

jcorbier · 2025-07-13T06:01:16Z

Pull request still being worked on, waiting for main PR on optee_os to be merged.

github-actions · 2025-08-14T02:22:31Z

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.

nathan-menhorn · 2025-08-14T15:36:14Z

Comment to keep this open.

github-actions · 2025-09-14T02:06:50Z

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.

jenswi-linaro reviewed Feb 7, 2025

View reviewed changes

jcorbier force-pushed the versal_net_port branch from a1385d2 to 362e096 Compare February 7, 2025 15:15

github-actions bot added the Stale label Mar 10, 2025

jcorbier force-pushed the versal_net_port branch from 362e096 to 5acf6af Compare March 10, 2025 10:15

jockebech removed the Stale label Mar 10, 2025

jenswi-linaro reviewed Mar 10, 2025

View reviewed changes

jcorbier force-pushed the versal_net_port branch from 5acf6af to 1eba217 Compare April 4, 2025 15:57

github-actions bot added the Stale label May 5, 2025

jforissier removed the Stale label May 5, 2025

etienne-lms reviewed May 5, 2025

View reviewed changes

jcorbier force-pushed the versal_net_port branch from 1eba217 to 9b77b3a Compare May 5, 2025 14:51

jenswi-linaro reviewed May 6, 2025

View reviewed changes

jcorbier force-pushed the versal_net_port branch from 9b77b3a to b6fe94a Compare May 6, 2025 06:41

jcorbier force-pushed the versal_net_port branch from b6fe94a to 2ee59e9 Compare May 6, 2025 07:45

github-actions bot added the Stale label Jun 6, 2025

etienne-lms reviewed Jun 6, 2025

View reviewed changes

jcorbier added 2 commits June 6, 2025 17:12

platform: add AMD/Xilinx Versal Net

bc71ead

Add the AMD/Xilinx Versal Net Platform. Signed-off-by: Jeremie Corbier <[email protected]> Acked-by: Jens Wiklander <[email protected]> Acked-by: Etienne Carriere <[email protected]>

jcorbier force-pushed the versal_net_port branch from 2ee59e9 to bc71ead Compare June 6, 2025 15:13

github-actions bot closed this Jun 12, 2025

jockebech reopened this Jun 12, 2025

jockebech removed the Stale label Jun 12, 2025

github-actions bot added the Stale label Jul 13, 2025

github-actions bot removed the Stale label Jul 14, 2025

github-actions bot added the Stale label Aug 14, 2025

jforissier removed the Stale label Aug 14, 2025

github-actions bot added the Stale label Sep 14, 2025

github-actions bot closed this Sep 20, 2025


		The pin used can be modified in ``core/pta/versal/test_pta.c`` by changing ``GPIO_TEST_PIN_ID``.

		This test is available in the ``versal`` testsuite in ``xtest``:

Add Versal Net Documentation #261

Add Versal Net Documentation #261

Uh oh!

Conversation

jcorbier commented Feb 6, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 10, 2025

Uh oh!

jenswi-linaro commented Mar 10, 2025

Uh oh!

jcorbier commented Mar 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 5, 2025

Uh oh!

nathan-menhorn commented May 5, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

etienne-lms May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jcorbier commented May 5, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jenswi-linaro commented May 6, 2025

Uh oh!

github-actions bot commented Jun 6, 2025

Uh oh!

etienne-lms left a comment

Choose a reason for hiding this comment

Uh oh!

jcorbier commented Jun 12, 2025

Uh oh!

jockebech commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jcorbier commented Jun 12, 2025

Uh oh!

github-actions bot commented Jul 13, 2025

Uh oh!

jcorbier commented Jul 13, 2025

Uh oh!

github-actions bot commented Aug 14, 2025

Uh oh!

nathan-menhorn commented Aug 14, 2025

Uh oh!

github-actions bot commented Sep 14, 2025

Uh oh!

Reviewers

Assignees

etienne-lms May 5, 2025 •

edited

Loading

jockebech commented Jun 12, 2025 •

edited

Loading