Skip to content

check for file size on upload. Make it 500mb? - #230

Open
LukeLoze1 wants to merge 2 commits into
mainfrom
457-large-sample-file-uploads-stuck-at-0-in-support-tool
Open

check for file size on upload. Make it 500mb?#230
LukeLoze1 wants to merge 2 commits into
mainfrom
457-large-sample-file-uploads-stuck-at-0-in-support-tool

Conversation

@LukeLoze1

Copy link
Copy Markdown
Contributor

Motivation and Context

If file to upload was too big it would blow up in the background (exceptions) but nothing at the frontend

What has changed

Put in support tool UI check for file size at 500mb
set backend limit to 500mb

How to test?

Should work fine locally to prove functionality. In standard dev GCP to test up to 500mb

Links

https://trello.com/c/aRjqwc8M/457-large-sample-file-uploads-stuck-at-0-in-support-tool

Screenshots (if appropriate):

@codecov

codecov Bot commented Oct 25, 2022

Copy link
Copy Markdown

Codecov Report

Merging #230 (0e0d817) into main (98d6388) will not change coverage.
The diff coverage is n/a.

❗ Current head 0e0d817 differs from pull request most recent head d13bae6. Consider uploading reports for the commit d13bae6 to get more accurate results

@@            Coverage Diff            @@
##               main     #230   +/-   ##
=========================================
  Coverage     51.87%   51.87%           
  Complexity      340      340           
=========================================
  Files            96       96           
  Lines          2394     2394           
  Branches        125      125           
=========================================
  Hits           1242     1242           
  Misses         1093     1093           
  Partials         59       59           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LukeLoze1 LukeLoze1 added the do not merge Do not merge this pull request label Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Do not merge this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant