check for file size on upload. Make it 500mb? - #230
Open
LukeLoze1 wants to merge 2 commits into
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## main #230 +/- ##
=========================================
Coverage 51.87% 51.87%
Complexity 340 340
=========================================
Files 96 96
Lines 2394 2394
Branches 125 125
=========================================
Hits 1242 1242
Misses 1093 1093
Partials 59 59 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
If file to upload was too big it would blow up in the background (exceptions) but nothing at the frontend
What has changed
Put in support tool UI check for file size at 500mb
set backend limit to 500mb
How to test?
Should work fine locally to prove functionality. In standard dev GCP to test up to 500mb
Links
https://trello.com/c/aRjqwc8M/457-large-sample-file-uploads-stuck-at-0-in-support-tool
Screenshots (if appropriate):