Skip to content

add tests for dcm#4

Open
andre-urbani wants to merge 1 commit into
mainfrom
feature/dcm-tests
Open

add tests for dcm#4
andre-urbani wants to merge 1 commit into
mainfrom
feature/dcm-tests

Conversation

@andre-urbani

@andre-urbani andre-urbani commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

What

Added the following tests for the DCM -

  • view the DCM homepage
  • find a dataset and version
  • search for a dataset by ID
  • search for a dataset with an invalid ID
  • create a new dataset series
  • create a new edition for a dataset series
  • create a new version for a dataset edition

Jira - https://officefornationalstatistics.atlassian.net/jira/software/c/projects/DIS/boards/1822?selectedIssue=DIS-5059

How to review

Run make test and confirm that all tests pass
There is a current issue in dis-data-admin-ui that @jondewijones will be creating a fix for. If that fix hasn't gone through by the time this PR is reviewed, you will have to change the following code locally otherwise some of the tests will not work. On this line in dis-data-admin-ui - https://github.com/ONSdigital/dis-data-admin-ui/blob/develop/src/utils/config/config.js#L6 - replace it with -

const getAPIRouterURL = (envVars) => {
    const apiRouterURL = envVars.API_ROUTER_URL;
    if (apiRouterURL.includes("dp-api-router:23200")) {
        return "http://localhost:23200/v1";
    }
    return apiRouterURL || null;
};

You may also have to do a make refresh on the dis-data-admin-ui, dp-files-api and dp-upload-service

Confirm changes make sense

Who can review

Anyone

@andre-urbani
andre-urbani requested a review from a team as a code owner July 23, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant