fix(cine): prevent crash on second view/hydration of SR series #5724
+47
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-dev canceled.
|
GhadeerAlbattarni
changed the title
jbocce
reviewed
Jan 26, 2026
|
|
||
| function _getVolumeFromViewport(viewport: Types.IBaseVolumeViewport) { | ||
| // Handle non-volume viewports that don't have getAllVolumeIds | ||
| if (!viewport || !viewport.getAllVolumeIds) { |
Collaborator
There was a problem hiding this comment.
Consider changing this to if(!viewport?.getAllVolumeIds) {
jbocce
requested changes
Jan 26, 2026
Collaborator
jbocce
left a comment
jbocce
left a comment
There was a problem hiding this comment.
Thanks so much. The change looks great - one small comment to address. Also let's add a playwright test to make sure this does not happen again. See https://docs.ohif.org/development/playwright-testing/ for more information.
Collaborator
|
Please update your branch with master. Thanks. |
Contributor
Author
|
Sure, thanks for your comments! |
GhadeerAlbattarni
force-pushed
the
fix/5634-sr-viewport-crash
branch
from
9c14c59 to
9936d9a
Compare
jbocce
approved these changes
Jan 27, 2026
Collaborator
jbocce
left a comment
jbocce
left a comment
There was a problem hiding this comment.
Thanks so much for this! I am approving the PR but will not merge until we release 3.12. It will be in for 3.13.
Collaborator
|
The changes to the OHIF docs look good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #5634
When an SR series is viewed/opened for the second time (via double-click or drag-and-drop), it causes a crash with
TypeError: getAllVolumeIds is not a functionbecause the cine service assumes all viewports are volume viewports.Changes
initCineService.tsto return early whengetAllVolumeIdsis not available.Results
The viewer no longer crashes when you reopen the SR series
Before:
Reopening an SR series causes OHIF to crash with
getAllVolumeIds is not a function.After:
SR series can be reopened without causing any crash or errors.
Testing
StudyInstanceUIDs=1.3.6.1.4.1.14519.5.2.1.7310.5101.860473186348887719777907797922Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment