Skip to content

Conversation

@jbocce
Copy link
Collaborator

@jbocce jbocce commented Jan 8, 2026

Context

Fixes #5651

Changes & Results

List surface representations in the segmentation table for 3D views. This was done by using an array of representation types instead of a single type for a panel. The first element of the array is the primary type of the panel, and the rest are secondary types that can also be displayed in the panel.

Testing

See #5651.

In general, only label maps will be viewable as surfaces in 3D viewports. So some simple steps to test are...

  1. Launch a study.
  2. Add a label map segmentation.
  3. Use the brush tool to add a circle or sphere.
  4. Switch to a view that contains 3D.
  5. The label map side panel should list the label maps (that were converted to surfaces).
  6. Most tools and functions should not be available but some functions will be such as hide/show segments, remove/remove segmentation. In general the feature set availability should be consistent with what existed in https://viewer.ohif.org/ for this scenario.
  7. There should be no arrows to navigate the segments in the top-right of the viewport.
  8. Clicking a segment should do nothing (i.e. no navigation via a segment click).

A bit of regression testing around both the label map and contour panels is necessary because the fix touched a few of the panel components. Best to try various functions and tools in each panel.

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

System:
OS: Windows 11 10.0.26200
CPU: (20) x64 12th Gen Intel(R) Core(TM) i7-12700H
Memory: 5.92 GB / 31.68 GB
Binaries:
Node: 20.9.0 - C:\Users\joebo\AppData\Local\fnm_multishells\33444_1767618650410\node.EXE
Yarn: 1.22.22 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 10.1.0 - C:\Users\joebo\AppData\Local\fnm_multishells\33444_1767618650410\npm.CMD
bun: 1.2.23 - C:\Users\joebo.bun\bin\bun.EXE
Browsers:
Chrome: 143.0.7499.170

…able for 3D views.

This was done by using an array of representation types instead of a single type for a panel.
The first element of the array is the primary type of the panel, and the rest are secondary types
that can also be displayed in the panel.
@netlify
Copy link

netlify bot commented Jan 8, 2026

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 5ee0e21
🔍 Latest deploy log https://app.netlify.com/projects/ohif-dev/deploys/6961b90b6dd6f60008238fed
😎 Deploy Preview https://deploy-preview-5700--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jbocce jbocce marked this pull request as ready for review January 9, 2026 14:58
@jbocce jbocce changed the title DRAFT fix(segmentation): List surface representations in the segmentation table for 3D views. fix(segmentation): List surface representations in the segmentation table for 3D views. Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Segments missing when changing to 3D layout

1 participant