Skip to content

fix: NM multiframe with TimeSlotVector #5666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wayfarer3130 merged 6 commits into from
Jan 6, 2026
+10 −4
Merged

fix: NM multiframe with TimeSlotVector #5666

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
83c0843
fix(ViewportWindowLevel): add null checks for volumeActor in opacity …
sedghi Dec 14, 2025
9f84d20
refactor(ViewportWindowLevel): register histogram worker at module lo…
sedghi Dec 14, 2025
ca242e2
fix(Preclinical4D): add null check for viewportId and set frame rate …
sedghi Dec 14, 2025
bf0f784
fix(getSopClassHandlerModule): handle multiframe dynamic volumes by u…
sedghi Dec 19, 2025
a333eab
Merge branch 'master' into 4d-sssss
wayfarer3130 Jan 5, 2026
68f0739
Merge branch 'master' of https://github.com/OHIF/Viewers into 4d-sssss
sedghi Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions extensions/default/src/getSopClassHandlerModule.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { id } from './id';
import getDisplaySetMessages from './getDisplaySetMessages';
import getDisplaySetsFromUnsupportedSeries from './getDisplaySetsFromUnsupportedSeries';
import { chartHandler } from './SOPClassHandlers/chartSOPClassHandler';
import { metaData } from '@cornerstonejs/core';

const {
isImage,
Expand Down Expand Up @@ -50,11 +51,16 @@ function getDisplaySetInfo(instances) {
const timePoint = timePoints[0];
const instancesMap = new Map();

// O(n) to convert it into a map and O(1) to find each instance
instances.forEach(instance => instancesMap.set(instance.imageId, instance));

const firstTimePointInstances = timePoint.map(imageId => instancesMap.get(imageId));
let firstTimePointInstances;

if (instances[0].NumberOfFrames > 1 && timePoints.length > 1) {
// handle multiframe dynamic volume
firstTimePointInstances = timePoints[0].map(imageId => metaData.get('instance', imageId));
} else {
// O(n) to convert it into a map and O(1) to find each instance
instances.forEach(instance => instancesMap.set(instance.imageId, instance));
firstTimePointInstances = timePoint.map(imageId => instancesMap.get(imageId));
}
displaySetInfo = isDisplaySetReconstructable(firstTimePointInstances, appConfig);
} else {
displaySetInfo = isDisplaySetReconstructable(instances, appConfig);
Expand Down