Skip to content

Conversation

@Belbin-GK
Copy link
Contributor

@Belbin-GK Belbin-GK commented Dec 12, 2025

Context

Annotations drawn in one series are incorrectly re-applied to unrelated viewports after loading a new series with a different Frame of Reference UID

Fixes : #5597

Changes & Results

  • Fallback to a viewport with matching orientation when no corresponding displaySet is found.
  • Annotations now display only for the correct series and no longer appear in the active viewport when switching between studies or series with different Frame of Reference UIDs, ensuring accurate and consistent annotation behavior

Before:

result-5597-before.mp4

After:

result-5597-after.mp4

Testing

Sample url : https://viewer.ohif.org/viewer?StudyInstanceUIDs=1.2.840.113619.2.290.3.3767434740.232.1619607454.466

  • Load the URL.
  • Switch to MPR mode.
  • Draw a measurement on a viewport and on a different slice.
  • Load a series with a different Frame of Reference UID and select a different viewport.
  • Click on the previously drawn measurement from the measurement panel.

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: Windows 11
  • Node version: 22.12.0
  • Browser: Chrome 142.0.7444.176

…ing series with different Frame of Reference UID
@netlify
Copy link

netlify bot commented Dec 12, 2025

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 6a1e45f
🔍 Latest deploy log https://app.netlify.com/projects/ohif-dev/deploys/6944236dd055f300075ede7b
😎 Deploy Preview https://deploy-preview-5630--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@wayfarer3130 wayfarer3130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this - will approve if you can just split the very long function into the three different parts to get each

@wayfarer3130 wayfarer3130 merged commit 658994c into OHIF:master Dec 18, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Annotation incorrectly appears in the active viewport after switching series with different Frame of Reference UID

3 participants