-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
fix: prevent annotation from appearing in active viewport when switching series with different Frame of Reference UID #5630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wayfarer3130
merged 10 commits into
OHIF:master
from
Belbin-GK:fix/annotation-misplacement-on-series-switch
Dec 18, 2025
Merged
fix: prevent annotation from appearing in active viewport when switching series with different Frame of Reference UID #5630
wayfarer3130
merged 10 commits into
OHIF:master
from
Belbin-GK:fix/annotation-misplacement-on-series-switch
Dec 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing series with different Frame of Reference UID
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
extensions/cornerstone/src/services/ViewportService/CornerstoneViewportService.ts
Outdated
Show resolved
Hide resolved
Contributor
wayfarer3130
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this - will approve if you can just split the very long function into the three different parts to get each
extensions/cornerstone/src/services/ViewportService/CornerstoneViewportService.ts
Outdated
Show resolved
Hide resolved
extensions/cornerstone/src/services/ViewportService/CornerstoneViewportService.ts
Outdated
Show resolved
Hide resolved
extensions/cornerstone/src/services/ViewportService/CornerstoneViewportService.ts
Outdated
Show resolved
Hide resolved
…lacement-on-series-switch
…lacement-on-series-switch
wayfarer3130
approved these changes
Dec 17, 2025
…lacement-on-series-switch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Annotations drawn in one series are incorrectly re-applied to unrelated viewports after loading a new series with a different Frame of Reference UID
Fixes : #5597
Changes & Results
Before:
result-5597-before.mp4
After:
result-5597-after.mp4
Testing
Sample url : https://viewer.ohif.org/viewer?StudyInstanceUIDs=1.2.840.113619.2.290.3.3767434740.232.1619607454.466
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment