Skip to content

fix(prediction): show algorithm names with modelType fallback#411

Open
egillax wants to merge 1 commit intoOHDSI:developfrom
mi-erasmusmc:prediction-algorithm-name-display
Open

fix(prediction): show algorithm names with modelType fallback#411
egillax wants to merge 1 commit intoOHDSI:developfrom
mi-erasmusmc:prediction-algorithm-name-display

Conversation

@egillax
Copy link

@egillax egillax commented Mar 4, 2026

Summary

  • normalize prediction performance rows to always include algorithmName, falling back to modelType when missing/blank
  • use algorithmName in model/hyperparameter selector labels while keeping modelType in parentheses
  • add Algorithm column to the main performance selection table and remove placeholder madeUp column

Why

Shiny model and hyperparameter views were showing generic binary/survival labels instead of algorithm labels, and could break when legacy result schemas lacked algorithmName.

Validation

  • ran devtools::test(filter = "patient-level-prediction-(main|model)")
  • added tests for algorithm-name normalization and fallback behavior in selectors

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.23%. Comparing base (6ad307c) to head (dd797e6).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #411      +/-   ##
===========================================
+ Coverage    80.22%   80.23%   +0.01%     
===========================================
  Files           70       70              
  Lines        22145    22159      +14     
===========================================
+ Hits         17766    17780      +14     
  Misses        4379     4379              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant