Refactor BufferedJsonReader async paths to reduce GC pressure #3380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
habbes
reviewed
Oct 9, 2025
| /// </summary> | ||
| /// <returns>A Stream used to read a stream value</returns> | ||
| [System.Diagnostics.CodeAnalysis.SuppressMessage("Performance", "CA1825:Avoid zero-length array allocations.", Justification = "<Pending>")] | ||
| [SuppressMessage("Performance", "CA1825:Avoid zero-length array allocations.", Justification = "<Pending>")] |
There was a problem hiding this comment.
Is this still relevant? Where are we doing a zero-lengh array allocation in this method?
habbes
reviewed
Oct 9, 2025
| BufferedNode node = this.currentBufferedNode; | ||
| if (node.Value is string || node.Value == null || node.NodeType == JsonNodeType.StartArray || node.NodeType == JsonNodeType.StartObject) | ||
| { | ||
| return CachedTasks.True; |
There was a problem hiding this comment.
Does this lead to an improvement over Task.FromResult(false) (which already returns a cached result)? I guess your approach avoids the overhead of type checks, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes #3359.
Description
Refactor
BufferedJsonReaderasync paths to reduce GC pressureChecklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.
Repository notes
Team members can start a CI build by adding a comment with the text
/AzurePipelines runto a PR. A bot may respond indicating that there is no pipeline associated with the pull request. This can be ignored if the build is triggered.Team members should not trigger a build this way for pull requests coming from forked repositories. They should instead trigger the build manually by setting the "branch" to
refs/pull/{prId}/mergewhere{prId}is the ID of the PR.