Support deserialization of Delta<T> payloads with ID preceding @removed annotation #3367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WanjohiSammy
requested review from
gathogojr,
habbes,
marabooy and
mikepizzo
WanjohiSammy
force-pushed
the
fix/disc-1523-resolve-unordered-delta-request
branch
from
33cf763 to
fb972f7
Compare
WanjohiSammy
force-pushed
the
fix/disc-1523-resolve-unordered-delta-request
branch
from
fb972f7 to
b295438
Compare
WanjohiSammy
force-pushed
the
fix/disc-1523-resolve-unordered-delta-request
branch
from
b295438 to
008e962
Compare
|
/AzurePipelines run |
…://github.com/OData/odata.net into fix/disc-1523-resolve-unordered-delta-request
WanjohiSammy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes
OData/AspNetCoreOData#1523
Description
This PR enhances the deserialization logic for Delta payloads to correctly handle cases where the ID property appears before the @removed annotation in the JSON structure.
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.
Repository notes
Team members can start a CI build by adding a comment with the text
/AzurePipelines runto a PR. A bot may respond indicating that there is no pipeline associated with the pull request. This can be ignored if the build is triggered.Team members should not trigger a build this way for pull requests coming from forked repositories. They should instead trigger the build manually by setting the "branch" to
refs/pull/{prId}/mergewhere{prId}is the ID of the PR.