Port Key As Segment Tests #3172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntionsTests, DollarSegmentTests and LiteralFormatTests
WanjohiSammy
requested review from
marabooy,
habbes,
xuzhg,
gathogojr and
Copilot
There was a problem hiding this comment.
Copilot reviewed 5 out of 15 changed files in this pull request and generated no comments.
Files not reviewed (10)
- test/EndToEndTests/Tests/Client/Microsoft.OData.Client.E2E.Tests/Common/Client/EndToEnd/EndToEndServiceCsdl.xml: Language not supported
- test/EndToEndTests/Tests/Client/Microsoft.OData.Client.E2E.Tests/KeyAsSegmentTests/Tests/UpdateTests.cs: Evaluated as low risk
- test/EndToEndTests/Tests/Client/Microsoft.OData.Client.E2E.Tests/KeyAsSegmentTests/Tests/StreamTests.cs: Evaluated as low risk
- test/EndToEndTests/Tests/Client/Microsoft.OData.Client.E2E.Tests/KeyAsSegmentTests/Tests/LiteralFormatTests.cs: Evaluated as low risk
- test/EndToEndTests/Tests/Client/Microsoft.OData.Client.E2E.Tests/Common/Server/EndToEnd/CommonEndToEndDataModel.cs: Evaluated as low risk
- test/EndToEndTests/Tests/Client/Microsoft.OData.Client.E2E.Tests/Common/Client/EndToEnd/DefaultContainer.cs: Evaluated as low risk
- test/EndToEndTests/Tests/Client/Microsoft.OData.Client.E2E.Tests/KeyAsSegmentTests/Tests/ClientEndToEndTests.cs: Evaluated as low risk
- test/EndToEndTests/Tests/Client/Microsoft.OData.Client.E2E.Tests/KeyAsSegmentTests/Tests/KeyAsSegmentTestHelper.cs: Evaluated as low risk
- test/EndToEndTests/Tests/Client/Microsoft.OData.Client.E2E.Tests/KeyAsSegmentTests/Server/UpdateTestsController.cs: Evaluated as low risk
- test/EndToEndTests/Tests/Client/Microsoft.OData.Client.E2E.Tests/KeyAsSegmentTests/Server/LiteralFormatTestsController.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
test/EndToEndTests/Tests/Client/Microsoft.OData.Client.E2E.Tests/KeyAsSegmentTests/Tests/DefaultUrlConventionsTests.cs:65
- [nitpick] The error message could be more descriptive to help diagnose issues.
Assert.IsType<DataServiceClientException>(exception.InnerException);
habbes
reviewed
Jan 28, 2025
...Tests/Client/Microsoft.OData.Client.E2E.Tests/KeyAsSegmentTests/Tests/ClientEndToEndTests.cs
Outdated
Show resolved
Hide resolved
habbes
reviewed
Jan 28, 2025
...Tests/Client/Microsoft.OData.Client.E2E.Tests/KeyAsSegmentTests/Tests/ClientEndToEndTests.cs
Outdated
Show resolved
Hide resolved
habbes
reviewed
Jan 28, 2025
...Tests/Client/Microsoft.OData.Client.E2E.Tests/KeyAsSegmentTests/Tests/ClientEndToEndTests.cs
Outdated
Show resolved
Hide resolved
xuzhg
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes #xxx.
Description
Port
Key As Segment TestsfromWCFto useAspNetCoreODataChecklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.