Port QueryCount and CancellationToken tests #3167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WanjohiSammy
requested review from
Copilot,
marabooy,
habbes,
xuzhg and
gathogojr
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
test/EndToEndTests/Tests/Client/Microsoft.OData.Client.E2E.Tests/QueryCountTests/Server/QueryCountTestsController.cs:14
- The namespace should be 'Microsoft.OData.Client.E2E.Tests.QueryCountTests.Server' to match the file path and class purpose.
namespace Microsoft.OData.Client.E2E.Tests.QueryCountTests.Server;
| using Microsoft.AspNetCore.OData.Routing.Controllers; | ||
| using Microsoft.OData.Client.E2E.Tests.Common.Server.EndToEnd; | ||
|
|
||
| namespace Microsoft.OData.Client.E2E.Tests.DeltaTests.Server; |
There was a problem hiding this comment.
The semicolon should be replaced with a curly brace to properly define the namespace.
Suggested change
| namespace Microsoft.OData.Client.E2E.Tests.DeltaTests.Server; | |
| namespace Microsoft.OData.Client.E2E.Tests.DeltaTests.Server { |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| return NotFound(); | ||
| } | ||
|
|
||
| customer.Orders ??= []; |
There was a problem hiding this comment.
The empty array initialization is incorrect.
Suggested change
| customer.Orders ??= []; | |
| customer.Orders ??= new List<Order>(); |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
xuzhg
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes #xxx.
Description
Port
Batch Request TestsfromWCFto useAspNetCoreODataChecklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.