add optional annotation location parameter to AddVocabularyAnnotation #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhg
requested changes
Dec 3, 2020
xuzhg
reviewed
Dec 9, 2020
| /// <param name="model">The model the annotation is added to.</param> | ||
| /// <param name="annotation">The annotation to be added.</param> | ||
| /// <param name="location">The location to add the allocation</param> | ||
| public static void AddVocabularyAnnotation(this EdmModel model, IEdmVocabularyAnnotation annotation, Csdl.EdmVocabularyAnnotationSerializationLocation location) |
There was a problem hiding this comment.
IEdmVocabularyAnnotation annotation, Csdl.EdmVocabularyAnnotationSerializationLocation location [](start = 72, length = 95)
It's not a deal for me to add such extensions. Because, there's only two line codes .
but, i have a question here: How can handle this scenario:
annotation itself has the Location setting, and that setting is different with the "location" given?
There was a problem hiding this comment.
I wasn't aware the IEdmVocabularyAnnotation has a location. Will look into it.
| /// <param name="model">The model the annotation is added to.</param> | ||
| /// <param name="annotation">The annotation to be added.</param> | ||
| /// <param name="location">The location to add the allocation</param> | ||
| public static void AddVocabularyAnnotation(this EdmModel model, IEdmVocabularyAnnotation annotation, Csdl.EdmVocabularyAnnotationSerializationLocation location) |
There was a problem hiding this comment.
nit: It's probably be good to add the Csdl namespace with a using statement
| public static void AddVocabularyAnnotation(this EdmModel model, IEdmVocabularyAnnotation annotation, Csdl.EdmVocabularyAnnotationSerializationLocation location) | ||
| { | ||
| model.AddVocabularyAnnotation(annotation); | ||
| annotation.SetSerializationLocation(model, location); |
There was a problem hiding this comment.
I'd love to see a unit test for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes issue #xxx.
Description
Briefly describe the changes of this pull request.
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.