Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serialization and deserialization of Dictionary<string, string> and Dictionary<string, object> #1589

Open
wants to merge 8 commits into
base: release-7.x
Choose a base branch
from
Open

Add serialization and deserialization of Dictionary<string, string> and Dictionary<string, object> #1589

wants to merge 8 commits into from

Conversation

bdebaere
Copy link
Contributor

Issues

This pull request fixes issue OData/WebApi#438

Description

This pull request adds serialization and deserialization of Dictionary<string, string>.

Checklist (Uncheck if it is not completed)

  • Test cases added
  • Build and test with one-click build and test script passed

@bdebaere
Copy link
Contributor Author

Note that I'm unsure whether registering the type as a PrimitiveType is how you saw the implementation.
I'm also unsure about what kind of test cases, if any, you'd like to see added.

@bdebaere
Copy link
Contributor Author

bdebaere commented Nov 1, 2019

Also requires new KeyValuePair<Type, IEdmPrimitiveType>(typeof(Dictionary<string, string>), GetPrimitiveType(EdmPrimitiveTypeKind.DictionaryOfStringString)), in Microsoft.AspNet.OData.Shared\Formatter\EdmLibHelpers.cs.

@xuzhg xuzhg added this to the vNext milestone Nov 6, 2019
@bdebaere
Copy link
Contributor Author

@mikepizzo Can you give me some points on how to proceed with this please?

@bdebaere bdebaere changed the title Add serialization and deserialization of Dictionary<string, string> Add serialization and deserialization of Dictionary<string, string> and Dictionary<string, object> Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KanishManuja-MS KanishManuja-MS Awaiting requested review from KanishManuja-MS

@xuzhg xuzhg Awaiting requested review from xuzhg

@mikepizzo mikepizzo Awaiting requested review from mikepizzo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
vNext
Development

Successfully merging this pull request may close these issues.
2 participants
@bdebaere @xuzhg