Copy over metadata selector when creating a copy of messagewritersett…

…ing (#1541) * Update ODataMessageWriterSettings.cs * Add test case for copy constructor
OData · Sep 17, 2019 · eb1a43f · eb1a43f
1 parent c64b897
commit eb1a43f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/Microsoft.OData.Core/ODataMessageWriterSettings.cs b/src/Microsoft.OData.Core/ODataMessageWriterSettings.cs
@@ -418,6 +418,7 @@ private void CopyFrom(ODataMessageWriterSettings other)
             this.useFormat = other.useFormat;
             this.Version = other.Version;
             this.LibraryCompatibility = other.LibraryCompatibility;
+            this.MetadataSelector = other.MetadataSelector;
 
             this.validations = other.validations;
             this.ThrowIfTypeConflictsWithMetadata = other.ThrowIfTypeConflictsWithMetadata;

diff --git a/test/FunctionalTests/Microsoft.OData.Core.Tests/ODataMessageWriterSettingsTests.cs b/test/FunctionalTests/Microsoft.OData.Core.Tests/ODataMessageWriterSettingsTests.cs
@@ -9,6 +9,7 @@
 using FluentAssertions;
 using Microsoft.OData.UriParser;
 using Microsoft.OData.Edm;
+using Microsoft.OData.Evaluation;
 using Xunit;
 using ODataErrorStrings = Microsoft.OData.Strings;
 
@@ -288,6 +289,14 @@ public void CopyConstructorShouldCopyServiceDocument()
             newSetting.MetadataDocumentUri.Should().Be(new Uri("http://test.org/$metadata"));
         }
 
+        [Fact]
+        public void CopyConstructorShouldCopyMetadataSelector()
+        {
+            this.settings.MetadataSelector = new TestMetadataSelector() { PropertyToOmit = "TestProperty" };
+            var newSetting = this.settings.Clone();
+            (newSetting.MetadataSelector as TestMetadataSelector).PropertyToOmit.Should().Be("TestProperty");
+        }
+
         [Fact]
         public void CopyConstructorShouldCopyODataUri()
         {