Batchhandler results in an error when doing bulk updates. #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="Nocore" |
|
Great catch, thanks! |
|
Fixed here: https://www.nuget.org/packages/Microsoft.Restier.AspNetCore/1.1.1-CI-20240706-232326 LMK if there are any issues, otherwise an RC build will go out next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
*This pull request fixes issue #760
Description
Concurrent dictionary to resolve the crashes.
Checklist (Uncheck if it is not completed)
Additional work necessary
Hopefully It won't have more concurrency errors. The default method doesn't resolve the requests all at the same time, and I don't believe it is tested properly after this change.