Throw exception in cases where no valid name can be created

OData · Apr 3, 2024 · 1f8bb27 · 1f8bb27
1 parent 5b08989
commit 1f8bb27
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/Microsoft.OData.CodeGen/Templates/ODataT4CodeGenerator.cs b/src/Microsoft.OData.CodeGen/Templates/ODataT4CodeGenerator.cs
@@ -3070,6 +3070,11 @@ private string GetValidIdentifier(string name)
             isFirst = false;
         }
 
+        if (validName.Length < 1)
+        {
+            throw new Exception($"Failed to make valid identifier for '{name}'");
+        }
+
         if (!char.IsLetter(validName[0]) && validName[0] != DefaultPrefixCharacter)
         {
             validName.Insert(0, DefaultPrefixCharacter);

diff --git a/src/Microsoft.OData.CodeGen/Templates/ODataT4CodeGenerator.ttinclude b/src/Microsoft.OData.CodeGen/Templates/ODataT4CodeGenerator.ttinclude
@@ -2925,6 +2925,11 @@ public abstract class ODataClientTemplate : TemplateBase
             isFirst = false;
         }
 
+        if (validName.Length < 1)
+        {
+            throw new Exception($"Failed to make valid identifier for '{name}'");
+        }
+
         if (!char.IsLetter(validName[0]) && validName[0] != DefaultPrefixCharacter)
         {
             validName.Insert(0, DefaultPrefixCharacter);