Fix case insensitive property selection #1482
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @CAPCHIK. Could you please add some test coverage to this pull request? It would help us better understand the specific scenario your change is addressing and ensure the behavior is preserved going forward. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On types where the names of properties differ only in case, the choice of a property at the CLR level breaks down, while OData allows you to have such names and processes them correctly.
The change does not change the number of test statuses. Before making the change, there were 7851 passed tests and 8 failed tests on my PC, and these numbers remained after making the changes. And the logic of selecting a property started working correctly, since by default, getting a property does not have an indication to ignore the case.
The behavior is reproduced in the repository, and the exception can be observed in the github action.