Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the time zone in ODataQuerySettings from the request context #1403

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

icnocop
Copy link

@icnocop icnocop commented Feb 1, 2025

Fixes #384

@@ -0,0 +1,44 @@
//-----------------------------------------------------------------------------
// <copyright file="ODataQueryOptionTests.cs" company=".NET Foundation">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
// <copyright file="ODataQueryOptionTests.cs" company=".NET Foundation">
// <copyright file="ODataQueryContextExtensionsTests.cs" company=".NET Foundation">

@WanjohiSammy
Copy link
Contributor

Please add an End-to-End test with this scenario:
https://github.com/OData/AspNetCoreOData/tree/main/test/Microsoft.AspNetCore.OData.E2E.Tests

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time zone settings not propagated to query
2 participants