Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDXDSYS-1692 fix admin2 ref logic, fix case when resource is deleted … #51

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

mcarans
Copy link
Collaborator

@mcarans mcarans commented Jan 23, 2025

…in operational presence, read admin 3 rows into operational presence (OCHA-DAP#219)

  • Some renaming of protected variables
  • Allow for duplicates
  • Fix adding dataset more than once
  • Allow admin 3 to be treated as admin 2 for operational presence - this means there can be duplicates which must be ignored
  • Prevent issue where dataset updated after operational presence has run and the required resource is deleted
  • Add changelog

…in operational presence, read admin 3 rows into operational presence (#219)

* Some renaming of protected variables
* Allow for duplicates
* Fix adding dataset more than once
* Allow admin 3 to be treated as admin 2 for operational presence - this means there can be duplicates which must be ignored
* Prevent issue where dataset updated after operational presence has run and the required resource is deleted
* Add changelog
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12939990272

Details

  • 126 of 132 (95.45%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 94.111%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/hapi/pipelines/database/humanitarian_needs.py 6 7 85.71%
src/hapi/pipelines/database/operational_presence.py 28 33 84.85%
Files with Coverage Reduction New Missed Lines %
src/hapi/pipelines/database/operational_presence.py 1 92.0%
src/hapi/pipelines/database/humanitarian_needs.py 1 96.92%
Totals Coverage Status
Change from base Build 12938041176: -0.2%
Covered Lines: 1566
Relevant Lines: 1664

💛 - Coveralls

@alexandru-m-g alexandru-m-g merged commit 2775b67 into OCHA-DAP:main Jan 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants