[16.0][FIX] stock_release_channel_partner_by_date: properly detect the exception #999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When searching a channel for a picking, if the channel has a warehouse then it must match otherwise the picking type must match
|
Hi @mt-software-de, @sebalix, |
jbaudoux
force-pushed
the
16.0-imp-stock_release_channel_partner_by_date-enforce_specific_channel_partner_date
branch
from
be5b179 to
c6be5de
Compare
Ensure warehouse is set on test channels
jbaudoux
force-pushed
the
16.0-imp-stock_release_channel_partner_by_date-enforce_specific_channel_partner_date
branch
from
c6be5de to
69488de
Compare
Fix compatilibity with stock_release_channel_partner_by_date. Domain must apply on channel so that we don't restrict partner specific channels.
jbaudoux
added
work in progress
no stale
santostelmo
approved these changes
Mar 31, 2025
sebalix
reviewed
Apr 1, 2025
| @@ -111,16 +111,22 @@ def _get_release_channel_possible_candidate_domain_channel(self): | |||
| return [ | |||
| ("is_manual_assignment", "=", False), | |||
| ("state", "!=", "asleep"), | |||
| "|", | |||
| ("picking_type_ids", "=", False), | |||
| ("picking_type_ids", "in", self.picking_type_id.ids), | |||
There was a problem hiding this comment.
Is it expected to use picking data in _get_release_channel_possible_candidate_domain_channel domain hook? I thought we designed it for basic criteria selection of the channel (like the ones already defined) without relying on current picking. For that we have _get_release_channel_possible_candidate_domain_picking.
There was a problem hiding this comment.
We need a domain to find out that the exception is valid for that warehouse & carrier but not picking type as it could be recomputed by the warehouse flow module.
I'll add docstring to those methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing compatibility with:
cc @sebalix @santostelmo