-
-
Notifications
You must be signed in to change notification settings - Fork 736
[19.0] [MIG] stock_partner_delivery_window
#2219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ivantodorovich
wants to merge
53
commits into
OCA:19.0
Choose a base branch
from
camptocamp:19.0-mig-stock_partner_delivery_window
base: 19.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[19.0] [MIG] stock_partner_delivery_window
#2219
ivantodorovich
wants to merge
53
commits into
OCA:19.0
from
camptocamp:19.0-mig-stock_partner_delivery_window
+2,212
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two small improvements: * add a hook to change the delivery time format * no need to display seconds, hh:mm is enough
…ry_time_preference The default value introduced by workdays feature breaks the installation of Demo databases as the change is not reflected in sale_partner_delivery_window.
… field is related
version conflict prevents upload to pypi
When copying partner, if the partner's delivery time preference is time window, time window ids should be copied as well.
Currently translated at 100.0% (27 of 27 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_partner_delivery_window Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_partner_delivery_window/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_partner_delivery_window Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_partner_delivery_window/
Currently translated at 100.0% (27 of 27 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_partner_delivery_window Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_partner_delivery_window/it/
Currently translated at 100.0% (27 of 27 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_partner_delivery_window Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_partner_delivery_window/it/
…erty on empty record
Allows to call this property without checking at first if the partner
exist, e.g.:
>>> list(picking.partner_id.delivery_time_weekdays)
Allow to check if a date is in window. Now works with date and datetime. This allows to check a delivery date without time.
Set warning when scheduled date is not set instead of raising error
Currently translated at 100.0% (26 of 26 strings) Translation: stock-logistics-workflow-18.0/stock-logistics-workflow-18.0-stock_partner_delivery_window Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-18-0/stock-logistics-workflow-18-0-stock_partner_delivery_window/it/
Improve warning when the delivery date is different from the scheduled date Improve coverage
Currently translated at 100.0% (28 of 28 strings) Translation: stock-logistics-workflow-18.0/stock-logistics-workflow-18.0-stock_partner_delivery_window Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-18-0/stock-logistics-workflow-18-0-stock_partner_delivery_window/it/
Currently translated at 100.0% (28 of 28 strings) Translation: stock-logistics-workflow-18.0/stock-logistics-workflow-18.0-stock_partner_delivery_window Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-18-0/stock-logistics-workflow-18-0-stock_partner_delivery_window/it/
091ccc0 to
8325483
Compare
ivantodorovich
commented
Jan 8, 2026
| "No scheduled date is set on the picking, cannot check", | ||
| time_window_picking.partner_delivery_window_warning, | ||
| ) | ||
| with mock.patch( |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not possible to set picking.scheduled_date = False in core, with stock_account module installed:
File "/opt/odoo/addons/stock_account/models/stock_picking.py", line 18, in _check_backdate_allowed
if picking._is_date_in_lock_period():
File "/opt/odoo/addons/stock_account/models/stock_picking.py", line 29, in _is_date_in_lock_period
lock = self.company_id._get_lock_date_violations(self.scheduled_date.date(), fiscalyear=True, sale=False, purchase=False, tax=False, hard=True)
AttributeError: 'bool' object has no attribute 'date'
Not really a bug in core neither, it's just not allowed.
8325483 to
31deeec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
partner_tzpartner-contact#2252base_time_windowserver-tools#3490