Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT][18.0][IMP] sign_oca: Add guided arrow flow to sign_oca #80

Open
wants to merge 2 commits into
base: 18.0
Choose a base branch
from
Open

[DRAFT][18.0][IMP] sign_oca: Add guided arrow flow to sign_oca #80

wants to merge 2 commits into from

Conversation

kobros-tech
Copy link

add arrow / guided flow to sign_oca

@OCA-git-bot
Copy link
Contributor

Hi @etobella,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza added this to the 18.0 milestone Jan 30, 2025
@kobros-tech kobros-tech force-pushed the 18.0-imp-sign_oca-3 branch 2 times, most recently from 324f59f to ab74e88 Compare January 30, 2025 23:16
@kobros-tech
Copy link
Author

This is how the arrow should look like:
@dnplkn

Screenshot from 2025-01-31 02-12-36

@kobros-tech
Copy link
Author

kobros-tech commented Feb 2, 2025 •
edited
Loading

A simple preliminary description video:
https://github.com/user-attachments/assets/95b00bf2-ede3-4680-80b0-743cffa9df62
@dnplkndll

etobella
etobella reviewed Feb 3, 2025
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You left a lot of console logs and comments to your name that don't have sense. Please remove them and add some comments on the functions explaining the goal of each one. I don't understand why you need to remove them from the core file if they are only used on a single place....

sign_oca/__manifest__.py
@@ -38,6 +40,9 @@
"sign_oca/static/src/components/sign_oca_pdf/sign_oca_pdf.xml",
"sign_oca/static/src/elements/elements.xml",
"sign_oca/static/src/scss/sign_oca.scss",
# kobros
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this comment?

sign_oca/__manifest__.py
@@ -77,6 +82,9 @@
"sign_oca/static/src/components/sign_oca_pdf_portal/sign_oca_pdf_portal.xml",
"sign_oca/static/src/elements/elements.xml",
"sign_oca/static/src/scss/sign_oca.scss",
# kobros
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

sign_oca/static/src/components/sign_oca_pdf_common/sign_oca_navigator.esm.js Outdated
* @param { Environment } env
*/
export function startSignItemNavigator(parent, target, types, env) {
console.log("types", types);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't leave this

sign_oca/static/src/components/sign_oca_pdf_common/sign_oca_navigator.esm.js Outdated
}

function scrollToSignItem({el: item, data}) {
console.log("item", item);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem

sign_oca/static/src/components/sign_oca_pdf_common/sign_oca_navigator.esm.js Outdated
},
];

console.log("signItemsToComplete2", signItemsToComplete2);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem

@victoralmau
Copy link
Member

Why are the changes of #78 also added here? I don't understand it.

@kobros-tech
Copy link
Author

hi all
thanks for contributing with me.

this module is under development, so if we can cooperate in the main important cause of it is more effective.

Once it is working as expected all normal procedures will be done.

Thanks all

@etobella etobella changed the title [18.0][IMP] sign_oca: Add guided arrow flow to sign_oca [DRAFT][18.0][IMP] sign_oca: Add guided arrow flow to sign_oca Feb 3, 2025
@kobros-tech kobros-tech force-pushed the 18.0-imp-sign_oca-3 branch 2 times, most recently from 2df9fcf to bd5a9ad Compare February 3, 2025 21:45
@kobros-tech
Copy link
Author

@dnplkndll
the scroll is good in firefox, but not functioning in chrome which needs some debugging.

Screencast.2025-02-04.02.05.27.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etobella etobella etobella left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.
5 participants
@kobros-tech @OCA-git-bot @victoralmau @etobella @pedrobaeza