-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD][WIP] account_avatax_exemption_sign_oca #79
base: 16.0
Are you sure you want to change the base?
[16.0][ADD][WIP] account_avatax_exemption_sign_oca #79
Conversation
@dnplkndll I will work on tests |
7842a38
to
fa73a89
Compare
fa73a89
to
bdee966
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Module account_avatax_exemption should be removed from MR as does not belong to this repo.
@api.depends("state") | ||
def _cancel_sign_request_id(self): | ||
for rec in self: | ||
if rec.state == "cancel": | ||
rec.sign_oca_request_id.cancel() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@api.depends("state") | |
def _cancel_sign_request_id(self): | |
for rec in self: | |
if rec.state == "cancel": | |
rec.sign_oca_request_id.cancel() | |
def write(self, vals): | |
if vals.get("state") == "cancel": | |
self.sign_oca_request_id.cancel() | |
res = super().write(vals) |
@api.depends only would be triggered to compute fields (don't apply in this field), so I suggest changing the logic to handle cases on write method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I added this module in a separate PR.
here I added it only because we wanted to test sign exemption and the module for exemption is not merged in 16.0 branch.
we tried to add it from the PR in test requirements as dependency but didn't succeed.
we can resume discussion about exemption module in its open PR for 16.0 branch.
account_avatax_exemption_sign_oca
proposing a new module to streamline the sale tax pdf exemption sign and storage using the sign_oca app and the account_avatax_exemption
we created and used this internal for several years now. Will be adding the account_avatax_exemption_dms next for paper based scan. not in digital signature and then hope to next gave a portal feature allowing the customer to upload or sign request a renewal requirement on a given state sales tax exemption
I wanted to propose the inclusion in oca with very general use case and can then complete test and migrate.
@JordiBForgeFlow @dreispt @atchuthan