Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] sign_oca: Add General settings menu item #69

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

victoralmau
Copy link
Member

FWP from 15.0: #68

Add General settings menu item

Please @pedrobaeza and @pilarvargas-tecnativa can you review it?

@Tecnativa TT41745

@OCA-git-bot
Copy link
Contributor

Hi @etobella,
some modules you are maintaining are being modified, check this out!

Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024-10-11_13-40

@pedrobaeza pedrobaeza added this to the 16.0 milestone Oct 11, 2024
@victoralmau victoralmau force-pushed the 16.0-imp-sign_oca-send_sign_request branch from 91afda2 to bd0afd1 Compare October 11, 2024 13:57
@victoralmau victoralmau force-pushed the 16.0-imp-sign_oca-send_sign_request branch from bd0afd1 to cf89aac Compare October 11, 2024 14:47
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In v15 it was slipped into the PR, but only for one item, so it was not so critical, but changes should be ordered for the commit history, and we have to avoid cosmetic changes most of the times.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-69-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a583717 into OCA:16.0 Oct 11, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2a874ca. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-imp-sign_oca-send_sign_request branch October 11, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants