Skip to content

[18.0][FIX] report_csv: add None check for docids in _render_csv #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deeniiz wants to merge 1 commit into
base: 18.0
Choose a base branch
from
+11 −1
Open

[18.0][FIX] report_csv: add None check for docids in _render_csv #1117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions report_csv/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,10 @@ Contributors

- Aung Ko Ko Lin

- `NuoBiT <https://www.nuobit.com>`__:

- Deniz Gallo [email protected]

Maintainers
-----------

Expand Down
2 changes: 1 addition & 1 deletion report_csv/models/ir_report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def _render_csv(self, report_ref, docids, data):
report_sudo = self._get_report(report_ref)
report_model_name = f"report.{report_sudo.report_name}"
report_model = self.env[report_model_name]
res_id = len(docids) == 1 and docids[0]
res_id = docids and len(docids) == 1 and docids[0]
if not res_id or not report_sudo.attachment or not report_sudo.attachment_use:
return report_model.with_context(
**{
Expand Down
2 changes: 2 additions & 0 deletions report_csv/readme/CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@
- Rattapong Chokmasermkul \<<[email protected]>\>
- [Quartile](https://www.quartile.co):
- Aung Ko Ko Lin
- [NuoBiT](https://www.nuobit.com):
- Deniz Gallo <[email protected]>
4 changes: 4 additions & 0 deletions report_csv/static/description/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,6 +471,10 @@ <h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
<li>Aung Ko Ko Lin</li>
</ul>
</li>
<li><a class="reference external" href="https://www.nuobit.com">NuoBiT</a>:<ul>
<li>Deniz Gallo <a class="reference external" href="mailto:dgallo&#64;nuobit.com">dgallo&#64;nuobit.com</a></li>
</ul>
</li>
</ul>
</div>
<div class="section" id="maintainers">
Expand Down