[16.0][FIX] product_variant_default_code: avoid unnecessary writes #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @Kev-Roche, |
Kev-Roche
suggested changes
Nov 28, 2025
Comment on lines
230
to
238
| def _generate_default_code(self): | ||
| value_codes = self.product_tmpl_id.attribute_line_ids.value_ids.mapped("code") | ||
| if (not self.code_prefix and self.product_tmpl_id.is_automask()) or not all( | ||
| value_codes | ||
| ): | ||
| return None | ||
| else: | ||
| if not self.product_tmpl_id.reference_mask: | ||
| return None |
Contributor
There was a problem hiding this comment.
Could be simplier:
Suggested change
| return None | |
| def _generate_default_code(self): | |
| value_codes = self.product_tmpl_id.attribute_line_ids.value_ids.mapped("code") | |
| if (not self.code_prefix and self.product_tmpl_id.is_automask()) or not all( | |
| value_codes or not self.product_tmpl_id.reference_mask | |
| ): | |
| return None | |
| else: |
IJOL
force-pushed
the
16.0-fix-default-code-serialization
branch
from
64599e2 to
dd6a477
Compare
Optimize default_code computation to avoid: - Unnecessary write operations when the value hasn't changed - PostgreSQL serialization errors in concurrent transactions - Processing when no reference_mask is defined (early return)
IJOL
force-pushed
the
16.0-fix-default-code-serialization
branch
from
dd6a477 to
a3beb7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimizes the default_code computation in product variants:
Avoid unnecessary writes: Only writes to default_code when the value actually changes. in db with many products makes upgrades faster
Early return without reference_mask: Returns None early in
_generate_default_code()when no reference_mask is defined, avoiding unnecessary processing, that was causing error during upgrades when database already contain many products and no automask setting is onTesting
Checklist