[18.0] [MIG] product_variant_configurator_manual_creation #406

marielejeune · 2025-06-02T14:09:30Z

Migration from version 15.0

Addon used since v14 without issue -> change development status to Beta.

Adding unit tests to make codecov succeed

Depends on #385

...gurator_manual_creation/wizards/wizard_product_variant_configurator_manual_creation_view.xml

marielejeune · 2025-09-22T06:35:22Z

As for now this PR depends on #404. It could depend on #409 but this PR looks abandoned too...

marielejeune · 2025-09-30T07:47:00Z

Changed dependency to #385 as it is the oldest and more mature PR.

marielejeune · 2025-09-30T09:37:07Z

@CILC98 I've fixed your suggestion and added a commit for improving unit tests and make codecov succeed. Can you re-review please?

CILC98 · 2025-10-01T00:59:53Z

@marielejeune Let's hope change proposal #385 is finalized. Does that sound okay to you?

marielejeune · 2025-10-01T07:57:05Z

@marielejeune Let's hope change proposal #385 is finalized. Does that sound okay to you?

If Pedro's comments are addressed it should be ok and almost ready to merge I think

rousseldenis · 2025-10-09T06:52:36Z

/ocabot migration product_variant_configurator_manual_creation

marielejeune · 2025-10-15T15:57:47Z

@CILC98 The product_variant_configurator module was merged. I've rebased this PR. Could you please update your review? We're almost there!

CILC98 · 2025-10-16T19:11:02Z

..._configurator_manual_creation/wizards/wizard_product_variant_configurator_manual_creation.py

+        if current_variants_to_create:
+            variants_to_show |= product_model.create(current_variants_to_create)
+        if variants_to_show:
+            action = self.env.ref("product.product_variant_action").read()[0]


Suggested change

action = self.env.ref("product.product_variant_action").read()[0]

action = self.env.ref("product.product_variant_action").sudo().read()[0]

@marielejeune Only the system administrator can read this model.

Right, changed

…ttier [MIG] product_variant_configurator_manual_creation: Migration to 14.0

Currently translated at 100.0% (22 of 22 strings) Translation: product-variant-15.0/product-variant-15.0-product_variant_configurator_manual_creation Translate-URL: https://translation.odoo-community.org/projects/product-variant-15-0/product-variant-15-0-product_variant_configurator_manual_creation/es/

Currently translated at 100.0% (22 of 22 strings) Translation: product-variant-15.0/product-variant-15.0-product_variant_configurator_manual_creation Translate-URL: https://translation.odoo-community.org/projects/product-variant-15-0/product-variant-15-0-product_variant_configurator_manual_creation/it/

…ts compute performance

…ixes

…s to Beta

…om product.product

marielejeune · 2026-01-05T09:59:17Z

Hi @StefanRijnhart
Even if I agree with Denis (to me we should avoid adding required fields without a default value if no logic asks it),
I've set product_variant_name as a rebel module so that we can merge this PR (which I rebased on 18.0).

StefanRijnhart · 2026-01-05T10:20:17Z

Yes, agreed that this is a more viable strategy in the long turn. Thanks for implementing the workaround!

/ocabot merge nobump

OCA-git-bot · 2026-01-05T10:20:24Z

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-406-by-StefanRijnhart-bump-nobump, awaiting test results.

OCA-git-bot · 2026-01-05T10:25:12Z

Congratulations, your PR was merged at c0a1126. Thanks a lot for contributing to OCA. ❤️

marielejeune force-pushed the 18.0-mig-product_variant_configurator_manual_creation branch 3 times, most recently from cfd06c4 to 75ab49a Compare June 3, 2025 07:28

marielejeune marked this pull request as ready for review June 3, 2025 07:31

marielejeune force-pushed the 18.0-mig-product_variant_configurator_manual_creation branch from 8694a00 to dc040b7 Compare June 3, 2025 09:23

jhemono mentioned this pull request Jun 23, 2025

18.0 mig product variant configurator manual creation ScalizerOrg/oca-product-variant#2

Merged

CILC98 suggested changes Sep 18, 2025

View reviewed changes

...gurator_manual_creation/wizards/wizard_product_variant_configurator_manual_creation_view.xml Outdated Show resolved Hide resolved

marielejeune force-pushed the 18.0-mig-product_variant_configurator_manual_creation branch from dc040b7 to 3ce56e8 Compare September 22, 2025 06:34

marielejeune force-pushed the 18.0-mig-product_variant_configurator_manual_creation branch from 3ce56e8 to a097094 Compare September 30, 2025 07:46

marielejeune force-pushed the 18.0-mig-product_variant_configurator_manual_creation branch 5 times, most recently from 2d51a7f to 7ebf033 Compare September 30, 2025 09:34

marielejeune requested a review from CILC98 September 30, 2025 09:37

OCA-git-bot added this to the 18.0 milestone Oct 9, 2025

OCA-git-bot mentioned this pull request Oct 9, 2025

Migration to version 18.0 #368

Open

9 tasks

rousseldenis added needs review migration labels Oct 9, 2025

rousseldenis approved these changes Oct 9, 2025

View reviewed changes

marielejeune force-pushed the 18.0-mig-product_variant_configurator_manual_creation branch from 7ebf033 to add1bde Compare October 15, 2025 15:48

CILC98 suggested changes Oct 16, 2025

View reviewed changes

marielejeune force-pushed the 18.0-mig-product_variant_configurator_manual_creation branch from add1bde to 0d49d80 Compare October 17, 2025 07:04

JasminSForgeFlow and others added 21 commits January 5, 2026 10:48

[IMP] product_variant_configurator_manual_creation

3dcbd3b

[UPD] Update product_variant_configurator_manual_creation.pot

9de47ba

[UPD] README.rst

aa9b9d2

[ADD] icon.png

d28c57b

[IMP] product_variant_configurator_manual_creation: black, isort, pre…

7a73e4e

…ttier [MIG] product_variant_configurator_manual_creation: Migration to 14.0

[MIG] product_variant_configurator_manual_creation: Migration to 15.0

6f2bd51

[UPD] Update product_variant_configurator_manual_creation.pot

59598de

[UPD] README.rst

96e73a2

[UPD] README.rst

fec36ec

Added translation using Weblate (Spanish)

0222880

Added translation using Weblate (Italian)

0912f43

[IMP]product_variant_configurator_manual_creation: has pending varian…

1d8b117

…ts compute performance

[BOT] post-merge updates

419a3d1

[IMP] product_variant_configurator_manual_creation: pre-commit auto f…

cf82cfd

…ixes

[MIG] product_variant_configurator_manual_creation: Migration to 18.0

ef91a01

[CHG] product_variant_configurator_manual_creation: development_statu…

3d0a859

…s to Beta

[IMP] product_variant_configurator_manual_creation: improve unit tests

09cef33

[FIX] product_variant_configurator_manual_creation: opening wizard fr…

b2fd898

…om product.product

[REF] product_variant_name: set as rebel module

cbd1432

marielejeune force-pushed the 18.0-mig-product_variant_configurator_manual_creation branch from 1e6668c to cbd1432 Compare January 5, 2026 09:52

OCA-git-bot added the bot is merging ⏳ label Jan 5, 2026

OCA-git-bot merged commit f4664c1 into OCA:18.0 Jan 5, 2026
9 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jan 5, 2026

	action = self.env.ref("product.product_variant_action").read()[0]
	action = self.env.ref("product.product_variant_action").sudo().read()[0]

Uh oh!

[18.0] [MIG] product_variant_configurator_manual_creation #406

[18.0] [MIG] product_variant_configurator_manual_creation #406

Uh oh!

Conversation

marielejeune commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

marielejeune commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marielejeune commented Sep 30, 2025

Uh oh!

marielejeune commented Sep 30, 2025

Uh oh!

CILC98 commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marielejeune commented Oct 1, 2025

Uh oh!

rousseldenis commented Oct 9, 2025

Uh oh!

marielejeune commented Oct 15, 2025

Uh oh!

CILC98 Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

CILC98 Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

marielejeune Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

marielejeune commented Jan 5, 2026

Uh oh!

StefanRijnhart commented Jan 5, 2026

Uh oh!

OCA-git-bot commented Jan 5, 2026

Uh oh!

Uh oh!

OCA-git-bot commented Jan 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

marielejeune commented Jun 2, 2025 •

edited

Loading

marielejeune commented Sep 22, 2025 •

edited

Loading

CILC98 commented Oct 1, 2025 •

edited

Loading