[18.0][MIG] product_variant_name: Migration to 18.0 #388

BhaveshHeliconia · 2025-01-17T07:44:41Z

No description provided.

marcelsavegnago

LGTM

rrebollo

Code Review: Great work! The code looks good to me (LGTM). Thank you for your contribution! I've provided a suggestion for your consideration—feel free to address it as you see fit.

rrebollo · 2025-06-25T18:31:48Z

product_variant_name/tests/test_product_variant_name.py

+from odoo.tests import TransactionCase
+
+
+class TestProductVariantName(TransactionCase):


You could use BaseCommon instead of TransactionCase

BhaveshHeliconia · 2025-06-26T05:44:59Z

@rrebollo : It's done. Thank you for your suggestion.

BhaveshHeliconia · 2025-07-21T06:05:21Z

Hey @OCA/product-maintainers Could you merge this ?

abdounasser202 · 2025-09-23T12:46:11Z

I did the migration and found this PR, so i won't push mine
@pedrobaeza please can you merge this ?

pedrobaeza

/ocabot migration product_variant_name

product_variant_name/models/product_product.py

Currently translated at 100.0% (3 of 3 strings) Translation: product-variant-16.0/product-variant-16.0-product_variant_name Translate-URL: https://translation.odoo-community.org/projects/product-variant-16-0/product-variant-16-0-product_variant_name/it/

Currently translated at 100.0% (3 of 3 strings) Translation: product-variant-16.0/product-variant-16.0-product_variant_name Translate-URL: https://translation.odoo-community.org/projects/product-variant-16-0/product-variant-16-0-product_variant_name/es/

trisdoan

LGTM!

Hello @pedrobaeza, could you take a look at this PR again please?

pedrobaeza · 2025-12-08T08:20:48Z

product_variant_name/init_hook.py

+        )
+
+
+def post_init_hook(env):


This one is now meaningless, as it's filled in pre.

Thanks, you're right

pedrobaeza

/ocabot merge nobump

OCA-git-bot · 2025-12-08T08:30:52Z

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-388-by-pedrobaeza-bump-nobump, awaiting test results.

Signed-off-by pedrobaeza

OCA-git-bot · 2025-12-08T08:32:59Z

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-388-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

pedrobaeza · 2025-12-08T08:34:08Z

product_variant_name/__init__.py

+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
+
+from . import models
+from .init_hook import pre_init_hook, post_init_hook


Suggested change

from .init_hook import pre_init_hook, post_init_hook

from .init_hook import pre_init_hook

pedrobaeza · 2025-12-08T08:49:44Z

/ocabot merge nobump

OCA-git-bot · 2025-12-08T08:49:52Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-388-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2025-12-08T08:54:12Z

Congratulations, your PR was merged at 126f1c6. Thanks a lot for contributing to OCA. ❤️

BhaveshHeliconia force-pushed the 18.0-mig-product_variant_name branch from fcf81fb to 59b49d5 Compare January 24, 2025 07:40

BhaveshHeliconia force-pushed the 18.0-mig-product_variant_name branch from 59b49d5 to d067f49 Compare February 6, 2025 11:27

BhaveshHeliconia force-pushed the 18.0-mig-product_variant_name branch from d067f49 to 3749b49 Compare March 31, 2025 09:36

marcelsavegnago approved these changes Mar 31, 2025

View reviewed changes

rrebollo approved these changes Jun 25, 2025

View reviewed changes

OCA-git-bot added approved labels Jun 25, 2025

BhaveshHeliconia force-pushed the 18.0-mig-product_variant_name branch from 3749b49 to 3da48a4 Compare June 26, 2025 05:35

pedrobaeza requested changes Sep 23, 2025

View reviewed changes

product_variant_name/models/product_product.py Outdated Show resolved Hide resolved

OCA-git-bot removed the approved label Sep 23, 2025

OCA-git-bot added this to the 18.0 milestone Sep 23, 2025

OCA-git-bot mentioned this pull request Sep 23, 2025

Migration to version 18.0 #368

Open

9 tasks

BhaveshHeliconia force-pushed the 18.0-mig-product_variant_name branch 3 times, most recently from 605fd8a to 20d796c Compare September 24, 2025 06:07

BhaveshHeliconia mentioned this pull request Sep 24, 2025

[18.0][FIX] resource_booking: fix test cases and deprecation warnings OCA/calendar#174

Closed

JordiMForgeFlow and others added 6 commits October 7, 2025 17:32

[ADD] product_variant_name

daa64c3

Added translation using Weblate (Italian)

3fd6df1

Added translation using Weblate (Spanish)

f4a3052

[IMP] product_variant_name: pre-commit auto fixes

ef54e61

BhaveshHeliconia force-pushed the 18.0-mig-product_variant_name branch 5 times, most recently from 3a488e1 to 9cc1081 Compare October 8, 2025 06:38

trisdoan approved these changes Dec 8, 2025

View reviewed changes

pedrobaeza reviewed Dec 8, 2025

View reviewed changes

BhaveshHeliconia force-pushed the 18.0-mig-product_variant_name branch from 9cc1081 to c8e18cc Compare December 8, 2025 08:29

pedrobaeza approved these changes Dec 8, 2025

View reviewed changes

OCA-git-bot added the approved label Dec 8, 2025

OCA-git-bot added a commit that referenced this pull request Dec 8, 2025

Merge PR #388 into 18.0

c0d1e09

Signed-off-by pedrobaeza

OCA-git-bot added the bot is merging ⏳ label Dec 8, 2025

OCA-git-bot removed the bot is merging ⏳ label Dec 8, 2025

[MIG] product_variant_name: Migration to 18.0

02830e1

pedrobaeza reviewed Dec 8, 2025

View reviewed changes

BhaveshHeliconia force-pushed the 18.0-mig-product_variant_name branch from c8e18cc to 02830e1 Compare December 8, 2025 08:34

OCA-git-bot added the bot is merging ⏳ label Dec 8, 2025

OCA-git-bot merged commit 23b9b06 into OCA:18.0 Dec 8, 2025
6 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 8, 2025

		from odoo.tests import TransactionCase


		class TestProductVariantName(TransactionCase):

	from .init_hook import pre_init_hook, post_init_hook
	from .init_hook import pre_init_hook

		)


		def post_init_hook(env):

Uh oh!

[18.0][MIG] product_variant_name: Migration to 18.0 #388

[18.0][MIG] product_variant_name: Migration to 18.0 #388

Uh oh!

Conversation

BhaveshHeliconia commented Jan 17, 2025

Uh oh!

marcelsavegnago left a comment

Choose a reason for hiding this comment

Uh oh!

rrebollo left a comment

Choose a reason for hiding this comment

Uh oh!

rrebollo Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

BhaveshHeliconia commented Jun 26, 2025

Uh oh!

BhaveshHeliconia commented Jul 21, 2025

Uh oh!

abdounasser202 commented Sep 23, 2025

Uh oh!

pedrobaeza left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

trisdoan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pedrobaeza Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

BhaveshHeliconia Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

pedrobaeza left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Dec 8, 2025

Uh oh!

OCA-git-bot commented Dec 8, 2025

Uh oh!

pedrobaeza Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Dec 8, 2025

Uh oh!

OCA-git-bot commented Dec 8, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Dec 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

trisdoan left a comment •

edited

Loading