[17.0][MIG] sale_variant_configurator: Migration to 17.0 #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
BhaveshHeliconia
force-pushed
the
17.0-mig-sale_variant_configurator
branch
from
46ad458 to
bf9f532
Compare
BhaveshHeliconia
force-pushed
the
17.0-mig-sale_variant_configurator
branch
from
bf9f532 to
cec0d65
Compare
Member
|
Please, cherry-pick #395 to commit history (before migration) |
BhaveshHeliconia
force-pushed
the
17.0-mig-sale_variant_configurator
branch
from
cec0d65 to
4a140b5
Compare
Contributor
Author
|
@victoralmau, Please Review! |
Member
|
Please, cherry-pick #398 to commit history (before migration) |
BhaveshHeliconia
force-pushed
the
17.0-mig-sale_variant_configurator
branch
2 times, most recently
from
76e28be to
7b59806
Compare
Contributor
Author
|
@victoralmau, Please Review.It's done. |
victoralmau
suggested changes
Feb 28, 2025
BhaveshHeliconia
force-pushed
the
17.0-mig-sale_variant_configurator
branch
from
7b59806 to
2b424d1
Compare
Contributor
Author
|
@victoralmau, Please Review all changes.it's done. |
victoralmau
suggested changes
Mar 14, 2025
Member
victoralmau
left a comment
victoralmau
left a comment
There was a problem hiding this comment.
Checking functionally I see that it does not work, can you check it?
BhaveshHeliconia
force-pushed
the
17.0-mig-sale_variant_configurator
branch
from
2b424d1 to
406f6fb
Compare
Contributor
Author
|
@victoralmau, Please Review.it's Fixed. |
victoralmau
approved these changes
Mar 17, 2025
Member
|
/ocabot migration sale_variant_configurator |
pedrobaeza
requested changes
Mar 17, 2025
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
You are destroying the previous README contents. You should transfer description, contributors, etc to the new fragment system.
Contributor
Author
|
https://github.com/OCA/product-variant/tree/16.0/sale_variant_configurator |
Member
|
As said, you have to transfer the contents of the previous README.rst to each fragment of the |
BhaveshHeliconia
force-pushed
the
17.0-mig-sale_variant_configurator
branch
from
406f6fb to
2fc2cdb
Compare
Contributor
Author
|
@pedrobaeza, Please review the updated README folder. |
pedrobaeza
reviewed
Mar 19, 2025
BhaveshHeliconia
force-pushed
the
17.0-mig-sale_variant_configurator
branch
from
2fc2cdb to
14fc5f4
Compare
pedrobaeza
reviewed
Sep 30, 2025
| attribute_price_extra = sum(line.product_attribute_ids.mapped("price_extra")) | ||
| self.assertEqual(attribute_price_extra, 10) | ||
| self.assertEqual(line.price_unit, 110) | ||
| self.assertEqual(line.price_extra, 10) |
Member
There was a problem hiding this comment.
Why do you remove this line?
BhaveshHeliconia
force-pushed
the
17.0-mig-sale_variant_configurator
branch
from
8eec33d to
5d8033c
Compare
Member
|
CI is red, so it seems the migration is still not correct. |
This comes from module sale_product_variants from odoomrp/odoomrp-wip.
- saleable products for Sale Orders. - purchable products for Purchase Orders.
Depending on the onchange order loaded in runtime, description put in the SO line might be the one got from the regular way. With this, we assure we get the proper description, and also in the partner language (using the trick with the partner field).
* Use generic method for creating the variant if needed * Create the variant when the sales is already confirmed
for some reason, after the creation of the product, the sale.order.line was emptied (e.g. product_tmpl_id was False) -> the onchange would do nothing. I split the test in two, and in the second test, I create the product before creating the sale order line.
…omer language As the model `sale.order.line` doesn't have `partner_id` field, the description is not populated in the customer language, as the automatism put in product_configurator makes use of this trick. For not adding such field that can conflict with other parts, let's overwrite the methods that populate the description and pass upstream the customer language in the context. TT33029
Currently translated at 100.0% (8 of 8 strings) Translation: product-variant-16.0/product-variant-16.0-sale_variant_configurator Translate-URL: https://translation.odoo-community.org/projects/product-variant-16-0/product-variant-16-0-sale_variant_configurator/pt_BR/
Steps to reproduce the error: - Go to Sales > Configuration and activate 'Units of Measure'. - Go to a quotation and add a line indicating a Product Template with several attributes (Conference Chair for example). - You must be able to select a unit of measure + the unit of measure is set automatically. Other versions (v13 for example) use another technique https://github.com/OCA/product-variant/blob/2922137d2de670010200fa0cb7cdf1469bffafbe/sale_variant_configurator/models/sale_order.py#L69 TT55223
…oduct_id field to filter correctly. TT57913
BhaveshHeliconia
force-pushed
the
17.0-mig-sale_variant_configurator
branch
from
5d8033c to
aeb1cb8
Compare
BhaveshHeliconia
force-pushed
the
17.0-mig-sale_variant_configurator
branch
from
aeb1cb8 to
75ba32a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.