Conversation
Contributor
|
Hi @legalsylvain, @Fkawala, |
UsmanGhias
reviewed
Sep 24, 2026
UsmanGhias
left a comment
UsmanGhias
left a comment
There was a problem hiding this comment.
Clean patch for OCA/pos.
Observations:
- Template and component structure preserves standard inheritance patterns.
Ready for testing on standard environments.
Best,
Usman
Contributor
|
hi @UsmanGhias. I didn't understood your comment ? did you reviewed this PR ? or used an AI ? thanks. |
Member
Author
|
@UsmanGhias please do not review draft prs. moreover, this looks to me like an automated review to increase your review count. |
|
Apologies Sylvain and Hugues. You are completely right. I was testing an automated review helper script and it fired erroneously on this draft PR. I apologize for the noise on your queue. I have completely disabled the script and will not post automated reviews here. Thanks for pointing it out. |
huguesdk
force-pushed
the
16.0-imp-pos_tare-send-tare-to-scale
branch
2 times, most recently
from
October 2, 2026 15:36
1c0cc7b to
15ee848
Compare
Co-authored-by: Sylvain LE GAL <sylvain.legal@grap.coop>
huguesdk
force-pushed
the
16.0-imp-pos_tare-send-tare-to-scale
branch
from
October 2, 2026 15:41
15ee848 to
a368f65
Compare
huguesdk
marked this pull request as ready for review
October 2, 2026 15:42
allow to round the tare value according to the precision of the weighing scale.
Co-authored-by: hugues de keyzer <odoo@hugues.info>
huguesdk
force-pushed
the
16.0-imp-pos_tare-send-tare-to-scale
branch
from
October 2, 2026 16:07
a368f65 to
de3858c
Compare
legalsylvain
approved these changes
Oct 2, 2026
| margin-top: -4px; | ||
|
|
||
| span::before { | ||
| content: "⚠️"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow to send tare when reading the scale value, to allow it to display the tare and the net weights (requires a compatible device proxy like odoo-driver).
in addition: