[16.0][FIX] pos_payment_change: Change of payment should force the session

[etobella]

Otherwise, something weird might happen. For example, if we have a rescue session and we try to do the change, the refund is assigned to another session, no the rescue one.

[OCA-git-bot]

Hi @legalsylvain,
some modules you are maintaining are being modified, check this out!

[legalsylvain]

I'm more in favor to reuse core feature.

something like

def _prepare_refund_values(self, current_session):
    session = current_session
    if force_session_id in self.env.context:
        session = self.env["pos.session"].browse(self.env.context.get("force_session_id")
    return super()._prepare_refund_values(session)

Then : only replace refund_result = self.refund() by refund_result = self.with_context(force_session_id=self.session_id.id)).refund()

Otherwise, LGTM. Thanks !

[etobella]

Sure! Not a problem 😄

[etobella]

@legalsylvain can you check it again?

[legalsylvain]

I'm not sure it will work if the session is closed. A test should be done on state. Dont you think ?

[etobella]

@legalsylvain Test added

[pedrobaeza]

@etobella what @legalsylvain means is to check in this method which is the state of the session.

[luisDIXMIT]

LGTM!

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[OCA-git-bot]

Hi @legalsylvain,
some modules you are maintaining are being modified, check this out!