Skip to content

[19.0][IMP] partner_stage: display stage_id in list view - #2273

Merged
OCA-git-bot merged 1 commit into
OCA:19.0from
camptocamp:19.0-imp-partner_stage
Mar 16, 2026
Merged

[19.0][IMP] partner_stage: display stage_id in list view#2273
OCA-git-bot merged 1 commit into
OCA:19.0from
camptocamp:19.0-imp-partner_stage

Conversation

@SilvioC2C

@SilvioC2C SilvioC2C commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

Based on top of #2215

luisDIXMIT
luisDIXMIT reviewed Feb 9, 2026
View reviewed changes

@luisDIXMIT luisDIXMIT left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an improvement commit? If so, why are there so many commits? There should be only one commit containing the improvement. The related PR with the migration was merged, so it might be better to start from the main 19.0 branch.

@imlopes

imlopes commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

Hello @SilvioC2C

Could you check the comment and rebase this PR?

The dependency was merged.

@SilvioC2C

SilvioC2C commented Feb 25, 2026

Copy link
Copy Markdown
Contributor Author

@luisDIXMIT this PR contains these many commits because it was based on top of #2215 which, back when this PR was first opened, was not yet merged.

@imlopes I'll rebase and push.

@SilvioC2C
SilvioC2C force-pushed the 19.0-imp-partner_stage branch from 30d055d to 4b8b9c3 Compare February 25, 2026 11:24
luisDIXMIT
luisDIXMIT approved these changes Mar 13, 2026
View reviewed changes

@luisDIXMIT luisDIXMIT left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and tested on runboat, LGTM!

@OCA-git-bot

OCA-git-bot commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@yankinmax
yankinmax force-pushed the 19.0-imp-partner_stage branch from 4b8b9c3 to 53f16d1 Compare March 16, 2026 12:35
@yankinmax

yankinmax commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

Hello @NL66278 can you pls take a look at this PR and possibly merge?

NL66278
NL66278 approved these changes Mar 16, 2026
View reviewed changes

@NL66278 NL66278 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@NL66278

NL66278 commented Mar 16, 2026

Copy link
Copy Markdown

/ocabot merge minor

@OCA-git-bot

OCA-git-bot commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 19.0-ocabot-merge-pr-2273-by-NL66278-bump-minor, awaiting test results.

@OCA-git-bot

OCA-git-bot commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 0167209. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot
OCA-git-bot merged commit 0c4f0a4 into OCA:19.0 Mar 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NL66278 NL66278 NL66278 approved these changes
+2 more reviewers
@yankinmax yankinmax yankinmax approved these changes
@luisDIXMIT luisDIXMIT luisDIXMIT approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@SilvioC2C @imlopes @OCA-git-bot @yankinmax @NL66278 @luisDIXMIT